similar to: [PATCH] generator: Some String parameters should be OptString (RHBZ#501894).

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From 20d557ef71df326280877f76777ab485be981d12 Mon Sep 17 00:00:00 2001 From: Richard Jones

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From 8cff35784c2227fa6ee114eaa49c30ef33882586 Mon Sep 17 00:00:00 2001 From: "Richard W.M.

The two patches attached allow 9p filesystems to be mounted and listed. Note that I did *not* test the new list-9p function, because I don't have a guest with a new enough kernel handy. 9p filesystems are not included in the output of list-filesystems. Because a lot of existing code feeds the output of list-filesystems directly into the input of mount-options, mount-ro or (even worse) plain

https://bugzilla.redhat.com/show_bug.cgi?id=667610 Original message from clalance: https://www.redhat.com/archives/libguestfs/2011-January/msg00014.html I believe that these 3 patches fix all of the issues that Chris has raised. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many

Two-part patch to fix RHBZ#580246. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From f5f43227870f4a2bedbd92361acdc3ca371a8418 Mon Sep 17 00:00:00 2001 From: Richard Jones

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From f2ac659a420bd22bfd69b087cf55edda2de97a11 Mon Sep 17 00:00:00 2001 From: Richard Jones

Original bug report: https://bugzilla.redhat.com/show_bug.cgi?id=576688 -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From

This patchset just fixes the 'hexdump' command as an example. The important part of the patch is #2 since that shows the approach I want to take to fix this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc.

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From 9a503ec7d7fa16e09abab53cc7f768b72020ce08 Mon Sep 17 00:00:00 2001 From: Richard Jones

Note this bug was very confusing because glob works when you use the -x (trace) option, so when you try to trace the commands being run the bug "disappears". Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc.

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From c1a227a960066fb9552e0c225bc473be365b67b0 Mon Sep 17 00:00:00 2001 From: Richard W.M. Jones

I've pushed this one already, so this is just 'FYI'. I tested it first on 5 different machines with: - latest upstream qemu - qemu-kvm from Fedora that contains the patch to fix the broken -machine option - qemu-kvm from Fedora, but with that patch removed - old qemu that predates the -machine option entirely - Debian 6 + qemu 0.14 Rich. -- Richard Jones, Virtualization

On Mon, May 18, 2020 at 11:12:29AM +0200, Pino Toscano wrote: > On Tuesday, 5 May 2020 17:44:15 CEST Richard W.M. Jones wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1828952#c2 > > I think we need to do a different approach than this patch. > > The biggest thing is that currently we check only SELINUXTYPE for the > actual policy, however we do not check SELINUX

This is a simple bug fix. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From cc560d9e43520b03e815ff4a7ae40faabd1f0162 Mon Sep 17 00:00:00 2001

What was wrong with detecting ENOTSUP and turning it into a warning then? For reference see: https://github.com/libguestfs/libguestfs/blob/master/sparsify/in_place.ml#L38-L46 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program

On Tue, May 31, 2016 at 12:06:15PM +0200, Pino Toscano wrote: > Run sudo with -n (non-interactive), so it will fail right away when not > configured to not require a password. This will avoid the connection to > time out. > --- > p2v/ssh.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/p2v/ssh.c b/p2v/ssh.c > index b432cbd..c6bf306 100644

On Tue, Aug 14, 2018 at 04:04:10PM +0200, Pino Toscano wrote: > When parsing the libvirt XML, make sure to assign the IDs for disks > (s_disk_id) from 0 instead of 1, just like all the other input modes not > based on libvirt XML. > --- > v2v/parse_libvirt_xml.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/v2v/parse_libvirt_xml.ml

On Wed, Dec 05, 2018 at 12:57:19PM +0100, Pino Toscano wrote: > Add few more characters for the devices of resume= entries in the > command line of grub: this way it is possible to match also /dev/mapper > devices. > > This should require no further processing, since the names of the > /dev/mapper devices do not change after the conversion. Yes this is what worried me, but I

On Wed, Mar 20, 2019 at 05:00:06PM +0100, Pino Toscano wrote: > Kernel modules can be also symlinks to files available outside the > "canonical" module directory; since `file` by default does not deference > symlinks, passing directly symlinks to the architecture detection > results in errors, as the "file" API does not recognize "symbolic link" > as