similar to: [PATCH] guestfish -i and virt-inspector work on filenames containing spaces (RHBZ#507810).

I'm still having trouble getting to grips with time classes. I wish to calculate the difference in days between events. Browse[1]> insp.j$First [1] "2002-02-19 13:00:00 NZDT" Browse[1]> spray.j$Date [1] "2001-11-29 13:00:00 NZDT" Browse[1]> insp.jk - spray.j$Date Time difference of 82 days If I save insp.jk to a vector, I get a nice useful value of 82.

At the moment the daemon code contains an incredibly hairy function called shell_quote for safely quoting strings passed to the shell. The patch replaces that with a glibc custom printf format (actually two, but very closely related), %Q and %R. %Q is like %s but it safely shell quotes the string. %R is like %Q but it prefixes the path with /sysroot. Example usage (w/o error checks):

Problem: We have a share defined using Samba 3.5.8 on AIX 6.1. Several people can map a Windows Network Drive to the share and it works fine. Several other people get Windows errors or system errors when trying to map a drive to the same share. Command line errors (from the net use command): System error 59 or System error 64 Windows Explorer error: The specified network name is no

For review only, this needs some clean up and more tests. My eyes are going cross-eyed looking at the calculate_offset_of_entry function, so time to take a break ... Rich.

The latter is a better way to disable the qemu display output as we need to, without enabling extra devices (which are disabled already, anyway). Also, related to the change above, ban the -display parameter from the ones that can be supplied by the user. --- configure.ac | 8 ++++---- src/launch-direct.c | 12 ++++++++---- src/launch.c | 1 + 3 files changed, 13 insertions(+), 8

v1 -> v2: - Rebase on top of Pino's version work. Two patches went upstream, these are the two remaining patches. Note the generation number is still inside the qemu.stat file. We could put it in the filename, I have no particular preference. Rich.

The patch I posted last week to disable mandatory locking for readonly drives (https://www.redhat.com/archives/libguestfs/2017-September/msg00013.html) was wrong in a couple of respects. Firstly it didn't work, which I didn't detect because my tests were testing the wrong thing. Oops. Secondly it used a simple version number check to detect qemu binaries implementing mandatory locking.

--- inspector/inspector.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/inspector/inspector.c b/inspector/inspector.c index 3583c61df..30d279987 100644 --- a/inspector/inspector.c +++ b/inspector/inspector.c @@ -347,6 +347,7 @@ output_root (xmlTextWriterPtr xo, char *root) char buf[32]; char *canonical_root; size_t size; + int is_bsd; XMLERROR

Doing qemu feature detection in the direct backend takes ~100ms because we need to run `qemu -help' and `qemu -devices ?', and each of those interacts with glibc's very slow link loader. Fixing the link loader is really hard. Instead memoize the output of those two commands. This patch series first separates all the code dealing with qemu into a separate module (src/qemu.c) and

v2 -> v3: - I addressed everything that Pino mentioned last time. - It's tricky to get a stable run when multiple copies of qemu are involved, because the same cache files get overwritten by parallel libguestfs. So I changed the names of the cache files to include the qemu binary key (size, mtime), which removes this conflict. This is in new patch 4/6. Rich.

Patches 1-4 are almost the same as they are when previously posted here: https://www.redhat.com/archives/libguestfs/2017-September/msg00039.html Patch 5 actually uses the mandatory locking test to turn off locking in the narrow case where a drive is opened readonly, and then only for the drive being inspected. Passes ordinary tests (‘check-direct’ and ‘check-valgrind-direct’). Rich.

On Thu, Oct 05, 2017 at 06:55:53PM +0200, Pino Toscano wrote: > On Thursday, 5 October 2017 17:36:09 CEST Richard W.M. Jones wrote: > > --- > > inspector/inspector.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/inspector/inspector.c b/inspector/inspector.c > > index 3583c61df..30d279987 100644 > > ---

Here are a few warning-removal changes for daemon/: >From eea38a1937ccd396603ed899d829d2982755ea4a Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Thu, 6 Aug 2009 15:25:03 +0200 Subject: [PATCH 1/4] define ATTRIBUTE_UNUSED * daemon/daemon.h (__attribute__, ATTRIBUTE_UNUSED): Define. --- daemon/daemon.h | 10 ++++++++++ 1 files changed, 10 insertions(+), 0

Run xmllint to validate the XML output files of virt-inspector, so the schema is checked against actual output of virt-inspector. --- inspector/test-virt-inspector.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/inspector/test-virt-inspector.sh b/inspector/test-virt-inspector.sh index 2f55cdc..33d749c 100755 --- a/inspector/test-virt-inspector.sh +++ b/inspector/test-virt-inspector.sh @@

Run xmllint to validate the XML output files of virt-inspector, so the schema is checked against actual output of virt-inspector. --- .gitignore | 1 + configure.ac | 2 ++ inspector/{test-virt-inspector.sh => test-virt-inspector.sh.in} | 2 ++ 3 files changed, 5 insertions(+) rename

This is a partial fix for https://bugzilla.redhat.com/show_bug.cgi?id=526717 Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://et.redhat.com/~rjones/libguestfs/ See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html -------------- next

--- inspector/virt-inspector.pod | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/inspector/virt-inspector.pod b/inspector/virt-inspector.pod index f8744b1..1282608 100644 --- a/inspector/virt-inspector.pod +++ b/inspector/virt-inspector.pod @@ -68,6 +68,12 @@ them with separate I<-a> options. The format of the disk image is auto-detected. To override this and force a particular

--- inspector/test-virt-inspector.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inspector/test-virt-inspector.sh b/inspector/test-virt-inspector.sh index 86d70a8..02bbcad 100755 --- a/inspector/test-virt-inspector.sh +++ b/inspector/test-virt-inspector.sh @@ -29,7 +29,7 @@ fi # ntfs-3g can't set UUIDs right now, so ignore just that <uuid>. diff_ignore="-I

--- inspector/inspector.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/inspector/inspector.c b/inspector/inspector.c index 3583c61df..d608b1b63 100644 --- a/inspector/inspector.c +++ b/inspector/inspector.c @@ -79,8 +79,8 @@ usage (int status) printf (_("%s: display information about a virtual machine\n" "Copyright (C) 2010 Red Hat

Hi I am wanting to time how long it takes a couple commands to run. I can do "time command" and it tells me. How do I do multple commands at a time. I tried: time command; command no good time "command; command" no good I can make a script I guess but thought there was a more elegant way. Thanks, jerry