similar to: [PATCH] daemon/Win32: use gnulib modules connect, socket and symlinkat (for readlinkat).

Quite a victory for Gnulib here. I was able to port a large part of the daemon just by adding some modules and fixing a few headers. The remaining issues which are *not* fixed are: * No chroot on Windows. * No sync(2) call. * No posix_fallocate call. * No futimes call. * No pread call. * No custom printf format specifiers. * Quite a few problems in guestfsd.c, eg. code to run external

gettime hash human memcpy openat-die openat-safer quote quotearg readlinkat save-cwd symlinkat timespec utimens xstrtol xstrtoll xstrtoumax xvasprintf I didnt track where they are uses, some of them arent used directly.

Hi Rich, Prompted by your "New commands to list devices by UUID and label" patch, I've adjusted it to use gnulib. While just compiling hash.[ch] is probably ok, in general (given the strict requirements of libguestfs) using the C files of a module is usually not an option, since you don't get the benefit of the module's m4 tests or automake snippets. For other modules,

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into Xen guests. http://et.redhat.com/~rjones/virt-p2v -------------- next part -------------- >From b76462f7433d064019382992163e3553c7906ee7 Mon Sep 17 00:00:00 2001 From: Richard Jones

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/ -------------- next part -------------- >From e61d5ab151899ff6e0b568e6cb40d3d3b600e54b Mon Sep 17 00:00:00 2001 From: Richard Jones <rjones at

This merely enforces (wrt gnulib) the existing convention that libguestfs is covered by LGPLv2+ . >From 99a8fab0fa0474b4ab3959a5bd5867779a1d08d6 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 26 Oct 2009 16:01:06 +0100 Subject: [PATCH libguestfs] build: tell gnulib-tool that this is an lgplv2+ library * bootstrap: Invoke gnulib-tool with --lgpl=2. ---

Remove gnulib modules that provide stuff clearly not used within libguestfs (library, daemon, and C tools). Among directly and indirectly modules used previous (and now no more), they are: cycle-check d-ino dev-ino dup3 dup3-tests fcntl-safer fcntl-safer-tests fdopendir fdopendir-tests filevercmp filevercmp-tests ftell ftell-tests ftello ftello-tests fts

This is an extended version of: https://www.redhat.com/archives/libguestfs/2019-September/msg00178.html It adds a couple of simple code changes, so it makes it possible to drop more modules. In addition, more unused modules were dropped. Pino Toscano (5): tests: switch away from xgetcwd daemon: move read_whole_file to common utils daemon: switch from read_file to read_whole_file daemon:

libguestfs (an LGPLv2+ library) uses the 'hash' module, which turns out to be "GPL". Actually this happened because we started to use it in a separate GPL'd utility program, but later on included this functionality in the core library, copying the same code from the utility but not checking the license of 'hash'. We'd therefore like to request that

Remove gnulib modules that provide stuff clearly not used within libguestfs (library, daemon, and C tools). Among directly and indirectly modules used previous (and now no more), they are: cycle-check dev-ino dup3 dup3-tests fcntl-safer fcntl-safer-tests filevercmp filevercmp-tests fts getaddrinfo getaddrinfo-tests hostent i-ring i-ring-tests inet_ntop

Hi, This series updates to the latest gnulib, after making most of its "make syntax-check" tests pass. There are still a few tests (listed in cfg.mk) that are simply skipped. To enable one, just remove its test name from the list of tests to skip and run "make syntax-check". [PATCH hivex 01/14] maint: add cfg.mk to prepare for syntax-check [PATCH hivex 02/14] maint: remove

-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top -------------- next part -------------- >From 42407dd684bf9abaa046eb173de8dad4f2f80419 Mon Sep 17 00:00:00 2001 From: Richard Jones

The warnings in daemon were aggravating and risky for development (too easy to miss new ones) so I spent some time last week and today working on removing them. The first patch gets us down to almost no warnings with the original -Wall setting. That was by far the hardest part. Once I'd done that, I enabled nearly all of gcc's warnings via gnulib's warnings and manywarnings modules

On Tue, Nov 5, 2013 at 7:51 AM, Richard W.M. Jones <rjones@redhat.com> wrote: > On Wed, Aug 28, 2013 at 06:51:11PM +0100, Richard W.M. Jones wrote: >> libguestfs (an LGPLv2+ library) uses the 'hash' module, which turns >> out to be "GPL". >> >> Actually this happened because we started to use it in a separate >> GPL'd utility program,

after creating a git clone I executed "bootstrap" and then entered "libguestfs/.gnulib/modules" and executed "grep -rn GPL * | grep ":GPL" | grep -v "build tool" > ~/GPLed" On Thu, Aug 22, 2013 at 11:05 AM, Richard W.M. Jones <rjones@redhat.com>wrote: > How did you construct this list? It appears to list modules which are > not

From: Jim Meyering <meyering at redhat.com> * lib/hivex.c (hivex_node_set_value): Remove unnecessary test-before-free. --- lib/hivex.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/hivex.c b/lib/hivex.c index d042f4f..a72fa77 100644 --- a/lib/hivex.c +++ b/lib/hivex.c @@ -2748,8 +2748,7 @@ hivex_node_set_value (hive_h *h, hive_node_h node, leave_partial:

On Wed, Jun 16, 2010 at 03:38:22PM -0700, Dwayne Fontenot <dwayne.fontenot at att.net> wrote: > Is lib/ supposed to be empty in febootstrap git HEAD? Yes. Run ./autogen.sh to populate it with gnulib stuff. Actually, this may not work too well unless you have gnulib checked out exactly in ../gnulib. I need to ask Jim Meyering nicely if he'll make gnulib into a submodule of

These patches first make src/ warning free, and then turn on the strict warning options. 75 0001-build-suppress-an-ignored-write-return-value-warning.patch 38 0002-build-suppress-an-ignored-dup-return-value-warning.patch 27 0003-generator.ml-suppress-signed-unsigned-compare-warnin.patch 48 0004-build-don-t-perform-arithmetic-on-void-pointers.patch 30

On Wed, Sep 18, 2019 at 06:51:15PM +0200, Pino Toscano wrote: > Remove gnulib modules that provide stuff clearly not used within > libguestfs (library, daemon, and C tools). Among directly and > indirectly modules used previous (and now no more), they are: > > cycle-check > dev-ino > dup3 > dup3-tests > fcntl-safer > fcntl-safer-tests > filevercmp

Nearly any program that writes to standard output can benefit from this sort of fix. Without it, running e.g., ./guestfish --version > /dev/full would exit successfully, even though it got ENOSPC when writing to the full device. That means regular output redirected to a file on a full partition may also fail to be written, and the error ignored. Before: $ guestfish --version >