similar to: [PATCH] supermin: Die with an error if no kernels found (RHBZ#539746).

This patch series fixes several problems in the way that supermin handles kernels. The most pressing problem is that supermin doesn't handle bogus vmlinuz files which aren't actual kernels. Along the way there is a lot of clean up. The patches look much better if you view them with ‘-w’. This series will require plenty of time to be tested in Fedora, especially on non-x86 arches.

* Richard W.M. Jones: > On Sat, Apr 26, 2014 at 02:27:07PM +0200, Hilko Bengen wrote: >> --- >> src/kernel.ml | 43 ++++++++++++++++++++++++++++--------------- >> 1 file changed, 28 insertions(+), 15 deletions(-) >> >> diff --git a/src/kernel.ml b/src/kernel.ml >> index ed5aea3..436b1b0 100644 >> --- a/src/kernel.ml >> +++ b/src/kernel.ml

--- src/kernel.ml | 43 ++++++++++++++++++++++++++++--------------- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/src/kernel.ml b/src/kernel.ml index ed5aea3..436b1b0 100644 --- a/src/kernel.ml +++ b/src/kernel.ml @@ -23,6 +23,19 @@ open Utils open Ext2fs open Fnmatch +let patt_of_cpu host_cpu = + let models = + match host_cpu with + | "mips" |

Hi Rich But there is no src/kernel.ml file on my ubuntu powerpc to which the above patch is reffering. I have installed supermin as supermin_5.1.8-2_powerpc.deb debian package. Thanks On Tue, Jun 3, 2014 at 7:16 PM, Richard W.M. Jones <rjones@redhat.com> wrote: > On Tue, Jun 03, 2014 at 06:55:49PM +0530, abhishek jain wrote: > > supermin: failed to find a suitable kernel

Hi Rich Kindly ignore my previos mail. I have downloaded the latest version of supermin supermin-5.1.8 and have compiled it for powerpc.Moreover there was no need to patch the src/ kernel.ml file as the changes were already implemented on the latest version. But still when i run libguestfs-test-tool on powerpc ubuntu,I get the below logs.. libguestfs-test-tool

This is an attempt to make supermin check for the existing results of an output when checking whether the appliance must be rebuilt using --if-newer. At the moment it is implemented only for the build mode, and for its ext2 output format. Pino Toscano (4): build: factor ext2 filenames Tighten Unix_error check for missing outputdir Extend modes with list of outputs build: set

This is an attempt to make supermin check for the existing results of an output when checking whether the appliance must be rebuilt using --if-newer. At the moment it is implemented only for the ext2 output format of the build mode. Changes from v1: - drop empty stub for the prepare mode - add patch to ignore --if-newer on modes different than build - squash patch with stub for the build mode

This two-part patch for supermin implements device trees (for ARM). The first patch introduces a more rational way to handle command line arguments in 'supermin-helper'. See the commit message for details. The old style is still supported for compatibility. The second patch adds an extra supermin-helper --dtb parameter specifying a wildcard. A device tree file which matches the

Document what each module does, using *.mli files. Remove the --dtb option, it's obsolete. Rename modules according to their purpose. Rich.

Why does the toplevel Makefile process appliance/, and creates supermin.d during make install, whith configure --disable-appliance? I have to double check what actually happens, it seems it causes startup failures if the resulting binary packages are started on a host that happens to have supermin installed. Olaf

On Wed, Jun 04, 2014 at 03:29:11PM +0530, abhishek jain wrote: > supermin: kernel: SUPERMIN_KERNEL environment variable /boot/uImage > supermin: failed to find a suitable kernel (host_cpu=powerpc64). > > I looked for kernels in /boot and modules in /lib/modules. If you follow the code in src/kernel.ml you'll see that this means supermin was unable to get the kernel version from

Hi, few cleanups in the supermin codebase; no actual functional change. Thanks, -- Pino Toscano (3): ext2: simplify tracking of visited modules utils: remove unused run_python function Add and use an helper error function src/build.ml | 20 +++++----------- src/dpkg.ml | 4 +--- src/ext2_initrd.ml | 10 ++++---- src/kernel.ml | 27

Hi all, As title, thanks a lot. My test host configurations: Linux desktop 3.0.0-14-generic #23-Ubuntu SMP Mon Nov 21 20:28:43 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux The test tool output as following: xxx at desktop:~$ sudo libguestfs-test-tool [sudo] password for xxx: ===== Test starts here ===== LIBGUESTFS_DEBUG=1 TMPDIR=(not set) libguestfs: new guestfs handle 0x16cd0f0 library version:

Move the handling of the SUPERMIN_* envvars, and the kernel copy/symlink out of find_kernel to build_kernel: this way find_kernel does only the search. Also, the modules path search is done in by find_kernel as well. This is mostly code motion, with no behaviour changes. --- src/kernel.ml | 89 +++++++++++++++++++++++++++++------------------------------ 1 file changed, 44 insertions(+), 45

Hi, to ease debugging issues with appliances (e.g. when used in libguestfs), using --include-packagelist will add a file containing the list of all the packages used. Thanks, Pino Toscano (3): ext2: add ext2fs_chmod and ext2fs_chown chroot: factor out file copy code Add --include-packagelist src/build.ml | 42 +++++++++++++++++++++++++------ src/chroot.ml | 29

Hi I have compiled libguestfs-1.26.1 on powerpc ubuntu using supermin_5.1.8-2_powerpc.deb as it dependency package. When I'm executing the binary libguestfs-test-tool on powerpc ubuntu,I'm getting supermin error... ATH=/bin:/sbin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/sbin:/usr/local/bin SELinux: sh: getenforce: command not found guestfs_get_append: (null) guestfs_get_autosync: 1

See patch #2 for more explanation. Pino Toscano (2): prepare: keep config_files available for longer prepare: create a really empty base.tar.gz with no config files src/mode_prepare.ml | 87 +++++++++++++++++++++++++++------------------ 1 file changed, 52 insertions(+), 35 deletions(-) -- 2.17.2

On Wed, Jun 04, 2014 at 02:25:58PM +0530, abhishek jain wrote: > Hi RIch > > > Below are the details of the powerpc ubuntu system ... > > ls -l /boot/ > total 10200 > -rw-r--r-- 1 root root 5224765 Nov 22 2013 uImage > -rw-r--r-- 1 root root 5192861 Nov 22 2013 uImage.orig > > > ls -l /lib/modules/ > total 4 > drwxr-xr-x 3 ubuntu ubuntu 4096 Jun 3

Hi all I am trying to run the dockerized version of linaro lava. Unfortunately it is not possible to start libguetsfs inside one of the containers. My settings are: Ubuntu Server 18.04.3, Docker version 18.09.7 running a Debian:stretch based contianer Running libguestfs-test-tool gives me the following output: root at e91c89e0874d:/# libguestfs-test-tool

This is a "merge" of two previous series: https://www.redhat.com/archives/libguestfs/2018-December/msg00015.html https://www.redhat.com/archives/libguestfs/2018-December/msg00020.html The goal is to handle better situations like: - empty file in the appliance directory - no config files available in the packages to include in an appliance Compared to the two series, the changes are: -