similar to: Windows port of daemon?

From: "Richard W.M. Jones" <rjones at redhat.com> Check /sbin, /usr/sbin, /bin and /usr/bin to ensure that neither the directory nor the parent (eg. /usr) is a symlink, and use this directory for the virtual directory used to store guestfsd in the appliance. --- appliance/Makefile.am | 9 +++++---- configure.ac | 20 ++++++++++++++++++++ 2 files changed, 25

Don't carry around Augeas lenses. It is fragile, since if the lens is added to upstream Augeas but the version number has not changed, then Augeas won't parse the target file at all. This specifically causes password adjustments to fail in RHEL 7.1. In future, if we need an Augeas lens, it must be added to Augeas, either upstream or as a downstream patch carried around by distros. ---

If you've ever tried to use this option, you'll know that it didn't work well. It broke random things (probably RHBZ#1020216, definitely RHBZ#1023630), and caused random failures generally, while often not actually failing when valgrind itself found problems. This does not remove the guestfs_internal_exit API. That will instead be modified in a future commit. ---

There is GUESTFSD_EXT_CMD defining a string for udevadm (so it is marked as "used tool" in the appliance), but it is not actually used when starting udevadm. There should be no behaviour change. --- daemon/guestfsd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/daemon/guestfsd.c b/daemon/guestfsd.c index 7b33a3a..4502190 100644 --- a/daemon/guestfsd.c +++

From: "Richard W.M. Jones" <rjones at redhat.com> This commit allows you to run the daemon under valgrind. You have to enable it at configure time: ./configure --enable-valgrind-daemon This should *not* be done for production builds. When this feature is enabled, valgrind is added to the appliance and the daemon is run under valgrind. Log messages from valgrind are passed

This option, used for testing, causes the daemon to create the Unix domain socket (from guestfs_channel), listen on it, and accept a single connection. --- daemon/guestfsd.c | 65 ++++++++++++++++++++++++++++++++++++++--------------- daemon/guestfsd.pod | 9 ++++++++ 2 files changed, 56 insertions(+), 18 deletions(-) diff --git a/daemon/guestfsd.c b/daemon/guestfsd.c index 8285d27..1bcdfa3

Signed-off-by: Chen Hanxiao <chenhanxiao@cn.fujitsu.com> --- appliance/packagelist.in | 1 + daemon/daemon.h | 2 ++ daemon/guestfsd.c | 19 +++++++++++++++++++ 3 files changed, 22 insertions(+) diff --git a/appliance/packagelist.in b/appliance/packagelist.in index 76c7293..d218a37 100644 --- a/appliance/packagelist.in +++ b/appliance/packagelist.in @@ -97,6 +97,7 @@ dnl

When the daemon starts up it creates a fresh (empty) LVM configuration and starts up lvmetad (which depends on the LVM configuration). However this appears to cause problems: Some types of PV seem to require lvmetad and don't work without it (https://bugzilla.redhat.com/show_bug.cgi?id=1581810). If we don't start lvmetad earlier, the device nodes are not created. Therefore move the

This refines the previous commit by shutting down the daemon cleanly at the end of the test (assuming the test was successful). It repurposes the 'internal_exit' API for this, which was previously used by the now defunct --enable-valgrind-daemon functionality. --- daemon/internal.c | 7 +------ generator/actions.ml | 3 ++- tests/daemon/captive-daemon.pm.in

In data giovedì 25 giugno 2015 14:50:03, Richard W.M. Jones ha scritto: > We had a chat about this on IRC, and I'm not very happy about any > patch that requires a special ./configure flag. I'm not sure where you see any special ./configure flag, other than what is already there (and not used much because makes things cumbersome). > We should find a way > to enable this

hi Mr Rich As you recommended, I switched to Fedora 16. I also built a guest machine with Fedora 16 Mini version. Inside the guest I? installed libguestfs-live-service package but I failed? to start the guestfsd daemon : ??? [root at Fedora16 ~]# guestfsd -vr ??? verbose daemon enabled ??? linux commmand line: BOOT_IMAGE=/vmlinuz-3.2.7-1.fc16.i686.PAE root=/dev/mapper/vg_fedora16-lv_root ??? ro

Linux from around 5.6 now enumerates individual disks in any order (whereas previously it enumerated only drivers in parallel). This means that /dev/sdX ordering is no longer stable - in particular we cannot be sure that /dev/sda inside the guest is the first disk that was attached to the appliance, /dev/sdb the second disk and so on. However we can still use SCSI PCI device numbering as found

This allows us to test the daemon running as a host process, allowing us to meaningfully test it using valgrind. This commit only adds a single test that check that the daemon starts up, can be pinged, and exits. --- .gitignore | 1 + Makefile.am | 1 + configure.ac | 2 + tests/daemon/Makefile.am | 36 +++++++++++

This allows us to test the daemon running as a host process, allowing us to meaningfully test it using valgrind. This commit only adds a single test that check that the daemon starts up, can be pinged, and exits. --- .gitignore | 1 + Makefile.am | 1 + configure.ac | 2 + tests/daemon/Makefile.am | 36 +++++++++++

Goodmornin, Since I am running ubuntu I did " nm -D /usr/lib64/libaugeas.so.0 | grep AUGEAS " and I didn't find "AUGEAS_0.16.0" , but I got this instead : 0000000000000000 A AUGEAS_0.1.0 0000000000000000 A AUGEAS_0.10.0 0000000000000000 A AUGEAS_0.11.0 0000000000000000 A AUGEAS_0.12.0 0000000000000000 A AUGEAS_0.14.0 0000000000000000 A AUGEAS_0.15.0 0000000000000000 A

We had a chat about this on IRC, and I'm not very happy about any patch that requires a special ./configure flag. We should find a way to enable this functionality for everyone in all builds, without impacting anyone who doesn't want to use it. I think: - remove the --enable-valgrind-daemon, for reasons outlined above (I posted a patch to do that yesterday) - have a new backend

On Thu, Jul 27, 2017 at 04:58:52PM +0200, Pino Toscano wrote: > Hi Olaf and Cédric, > > On Monday, 24 July 2017 18:10:12 CEST Richard W.M. Jones wrote: > > Replace GUESTFSD_EXT_CMD with a command line option > > ‘./guestfsd --print-external-commands’ > > This mini-series basically changes the way external programs used in > the appliance are collected; this was done

This commit, which is just code motion, moves the common XDR protocol code (libprotocol) and the common errno handling (liberrnostring) into libraries which are each built once and shared between the library and daemon. --- .gitignore | 20 +++++-------- Makefile.am | 1 + common/errnostring/Makefile.am | 45 +++++++++++++++++++++++++++++

This allows the Linux kernel command line to be specified on the program command line. --- daemon/guestfsd.c | 22 ++++++++++++++++++---- daemon/guestfsd.pod | 6 ++++++ 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/daemon/guestfsd.c b/daemon/guestfsd.c index eef24d5..190ade2 100644 --- a/daemon/guestfsd.c +++ b/daemon/guestfsd.c @@ -130,7 +130,7 @@ static void usage (void)

Thanks to the reminder from Dan Berrange, here's a patch to make build output less verbose, by default. E.g., instead of the redundant multi-line compilation/linking commands, you'll see something like this by default: CC guestfsd-fsck.o CC guestfsd-grep.o CC guestfsd-grub.o CC guestfsd-glob.o CC guestfsd-guestfsd.o CC guestfsd-headtail.o CC