similar to: [PATCH libguestfs] build: die early if we lack ocaml, ocamlfind or ocaml-xml-light

This reinstates the autogen.sh-based test for the two required ocaml packages. I've tested it by running autoconf.sh first with neither of the two packages installed, then with only ocaml-xml-light installed. In both cases, autogen.sh failed as required. When both were installed, it worked as expected. >From 825d855b225c7c76371c72eae4d505a32c374007 Mon Sep 17 00:00:00 2001 From: Jim

The series below makes changes like these mechanically, one class of change per change-set: strcmp(...) == 0 to STREQ(...) strcmp(...) != 0 to STRNEQ(...) strncmp(...) == 0 to STREQLEN(...) strncmp(...) != 0 to STRNEQLEN(...) strcasecmp(...) == 0 to STRCASEEQ(...) strcasecmp(...) != 0 to STRCASENEQ(...) strncasecmp(...) == 0 to STRCASEEQLEN(...)

syntax-check failed with this: fuse/guestmount.c:364: free ((char *) r); maint.mk: don't cast free argument make: *** [sc_cast_of_argument_to_free] Error 1 >From ed007e673b00ec545fcff2a708a57d98075c6460 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 9 Nov 2009 15:06:36 +0100 Subject: [PATCH libguestfs] avoid "syntax-check"

Similar: hivex/hivex.c maint.mk: the above files include <assert.h> but don't use it make: *** [sc_prohibit_assert_without_use] Error 1 >From a71e5791293ac1e794fecffee8a2d616777f77e0 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 9 Nov 2009 15:08:09 +0100 Subject: [PATCH libguestfs] placate 'make syntax-check' *

barely worth mentioning... >From 459fa00dd144aef2c7287eb99354c9b39eaa62c3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 9 Nov 2009 15:09:35 +0100 Subject: [PATCH libguestfs] fix doc typo * fuse/guestmount.pod: Avoid "the the". --- fuse/guestmount.pod | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fuse/guestmount.pod

Using 'ocamlfind ocamldoc' is much faster than running 'ocamldoc' directly, because ocamlfind will run the native code program 'ocamldoc.opt' if it is available. This change approximately halves the time taken to compile the ocaml bindings. --- ocaml/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index

One more after this, and "make syntax-check" will pass once more. >From 5c360133c0d4e09531d432abca0629798b87ff39 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Mon, 9 Nov 2009 15:14:53 +0100 Subject: [PATCH libguestfs] indent with spaces, not TABs * HACKING: Expand indentation TABs. * configure.ac: Likewise. * daemon/daemon.h: Likewise. *

Source: xen-api-libs Version: 0.5.2-3 Severity: serious Tags: jessie sid User: debian-qa at lists.debian.org Usertags: qa-ftbfs-20130620 qa-ftbfs Justification: FTBFS on amd64 Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part: > make[2]: Entering directory `/?PKGBUILDDIR?/stdext' > ocamlfind ocamlc -I ../xml-light2 -I ../stdext -I

On Mon, Aug 07, 2017 at 08:10:55AM -0500, Chris McIntosh wrote: > Hey Thanks Rich. > > > What distro? > Solus > > > Are the OCaml bindings for hivex actually installed? > I don't think so at this point, though make install runs this command: > > ocamlfind install \ > -ldconf ignore -destdir /home/chris/.opam/4.05.0/lib/ocaml \ > hivex \ > META

<https://github.com/Chocrates> Apologies if this is the wrong list, I initially opened a github ticket before reading that github isn't the right spot. Trying to compile libguestfs and in the process need to get hivex compiled and installed. Hivex compiles and installs fine (I think), but ocamlfind doesn't seem to pick up hivex after the install causing the autogen.sh script in

Here are four small patches. First, I enabled all the warnings, then I fixed the newly exposed offenses, then I put the warning-enabling patch at the end, for the sake of future bisectors: [1/4] ocaml/guestfs_c.c avoid signed/unsigned-comparison warning [2/4] ocaml/guestfs_c.c: avoid warning about initialization discarding "const" [3/4] ocaml/guestfs_c.c: avoid warning about missing

On those systems "$(OCAMLFIND) $(OCAMLBEST)" was resolved as "ocamlfind byte" which did not work. --- Makefile.am | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Makefile.am b/Makefile.am index 109d2c8..4dc6f12 100644 --- a/Makefile.am +++ b/Makefile.am @@ -56,18 +56,18 @@ SOURCES_ML = $(filter %.ml,$(SOURCES)) BOBJECTS =

This should make it possible to build useful OCaml bindings on architectures other than i386 and amd64 (Debian bug #589809). --- ocaml/Makefile.am | 30 +++++++++++++++--------------- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index b3f5e14..b9451e3 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -46,7 +46,7 @@ hivex_c.o:

Today I did it, for the very first time: Did not build a package. Just ran "make install". Twice! ... ocamlfind install \ -ldconf ignore -destdir /usr/lib64/ocaml \ guestfs \ META *.so *.a *.cma *.cmi ./*.mli *.cmx *.cmxa ocamlfind: Package guestfs is already installed - (file /usr/lib64/ocaml/guestfs/META already exists) Makefile:2053: recipe for target

Building 1.9.53 fails for me with ocaml 3.10.2 and 3.12.1, likely due to commit a0722c7ad846960be54978a31ebe73b76e119203: [ 318s] ocamlfind ocamlopt -g -warn-error CDEFLMPSUVYZX -package str -I ../src/.libs -I ../ocaml \ [ 318s] mlguestfs.cmxa -linkpkg ../fish/guestfish-progress.o progress-c.o resize_gettext.cmx resize_utils.cmx progress.cmx resize.cmx -cclib -lncurses -o virt-resize

Previously the OCaml compiler was only required if building from git but was at least theoretically optional if building from tarballs (although this was never tested). Since we want to write parts of the daemon in OCaml, this makes OCaml required for all builds. Note that the ‘--disable-ocaml’ option remains, but it now only disables OCaml bindings and OCaml virt tools. Using this option does

Once ocamlfind is installed, 'make' failed for me with: ocamlfind ocamlc -g -annot -safe-string -warn-error CDEFLMPSUVYZX+52-3 -ccopt '-gdwarf' -package unix -c NBD.ml -o NBD.cmo File "NBD.ml", line 1: Error: Could not find the .cmi file for interface NBD.mli. make[2]: *** [Makefile:823: NBD.cmo] Error 2 I'm not positive that this is the perfect fix, but it at least

I believe this patch has now been superseded by Hilko's commit here: https://github.com/libguestfs/libguestfs/commit/f75142c577255b30f2a8e1d27baa5fd185594197 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog: http://rwmj.wordpress.com Fedora now supports 80 OCaml packages (the OPEN alternative to F#)

There's a missing dependency in the ocaml subdirectory which causes this error whenever the main library changes: ocamlfind ocamlopt -cclib -L../src/.libs -I . unix.cmxa mlguestfs.cmxa t/guestfs_005_load.cmx -o t/guestfs_005_load File "_none_", line 1, characters 0-1: Error: Files t/guestfs_005_load.cmx and mlguestfs.cmxa make inconsistent assumptions over interface Guestfs

On Thu, Oct 16, 2014 at 11:09:08AM +0200, Olaf Hering wrote: > > Today I did it, for the very first time: > Did not build a package. Just ran "make install". Twice! > > ... > ocamlfind install \ > -ldconf ignore -destdir /usr/lib64/ocaml \ > guestfs \ > META *.so *.a *.cma *.cmi ./*.mli *.cmx *.cmxa > ocamlfind: Package guestfs is already installed