similar to: [PATCH] guestfish: Redirect stdout when executing remote commands

There's a new syntax check rule from gnulib. It requires that you write e.g., exit (EXIT_SUCCESS), not exit (0). And the same for 1/EXIT_FAILURE and any other constants. There were a lot of violations, including a few false positives, so I started with the exemptions (see the .x-sc file below). Then I converted the vast majority automatically, with this: maint: use EXIT_SUCCESS and

I want to compile tftp-hpa on libc5 because we have many systems still using this library. There were some constants missing that i copied from glibc-2.1 headers, and now I'm left with this and I don't know what to do since all I can do is copy/paste, not touch real code :-) === gcc -O2 -m486 -fno-strength-reduce -D_XPG4_2 -D_XOPEN_SOURCE -D__EXTENSIONS__ -D_BSD_SOURCE -D_ISO9X_SOURCE

Wherever we had code which did: if (something_bad) { perror (...); exit (EXIT_FAILURE); } replace this with use of the error(3) function: if (something_bad) error (EXIT_FAILURE, errno, ...); The error(3) function is supplied by glibc, or by gnulib on platforms which don't have it, and is much more flexible than perror(3). Since we already use error(3), there seems to be

Nearly any program that writes to standard output can benefit from this sort of fix. Without it, running e.g., ./guestfish --version > /dev/full would exit successfully, even though it got ENOSPC when writing to the full device. That means regular output redirected to a file on a full partition may also fail to be written, and the error ignored. Before: $ guestfish --version >

hello hpa, here my birthday submission :) please pull: git pull git://git.debian.org/users/maks/klibc.git maks Sam fixed a longstanding x86_32 build bug, thus it seems a good time to flush the queue of the piled up patches, the shortlog tells it: Aurelien Jarno (1): [klibc] sh4: syscalls fixes Benjamin Cama (1): [klibc] fstype: btrfs size endianness fix Mike Waychison (2):

HAVE_SENDMSG = 1 HAVE_ACCRIGHTS_IN_MSGHDR - not defined HAVE_CONTROL_IN_MSGHDR = 1 > void > mm_send_fd(int socket, int fd) > { > #if defined(HAVE_SENDMSG) && (defined(HAVE_ACCRIGHTS_IN_MSGHDR) || defined(HAVE_CONTROL_IN_MSGHDR)) > struct msghdr msg; > struct iovec vec; > char ch = '\0'; > int n; > #ifndef HAVE_ACCRIGHTS_IN_MSGHDR

Dear List, the attached patch makes rsync of local folders almost as fast as cp. when rsync client and server has detected that they are working in local_server mode, they use local_socket, a unix domain socket pair, to pass the file descriptors of the synced files. the server uses the file descriptor it receives from the client to fast copy from src to dst file. on completion of every file fast

On Thu, 26 Feb 2015, Damien Miller wrote: > > Yes I saw that later. > > > > The testsuite build fails on Solaris 2.6 thusly: > [...] > > regress/netcat.c:1037: error: 'struct msghdr' has no member named > > 'msg_control' > > ah, looks like we need to copy some bits from monitor_fdpass.c Perhaps like this: diff --git regress/netcat.c

Hi I've found that openssh-3.2.2p1 can't be compiled on my Linux 2.0.36, because it doesn't define CMSG_DATA and CMSG_FIRSTHDR in <linux/socket.h>. The patch below solved this problem. Regards, NIDE Maoyuki, nide at ics.nara-wu.ac.jp ------------------------------------------------------------------------ diff -ru openssh-3.2.2p1.orig/defines.h openssh-3.2.2p1/defines.h

On Tuesday 02 February 2016 19:47:12 Richard W.M. Jones wrote: > On Tue, Feb 02, 2016 at 03:27:39PM +0100, Pino Toscano wrote: > > diff --git a/src/launch.c b/src/launch.c > > index f59818f..ec061e3 100644 > > --- a/src/launch.c > > +++ b/src/launch.c > > @@ -418,6 +418,21 @@ guestfs_int_get_cpu_model (int kvm) > > #endif > > } > > > >

Will this perhaps fix these? imap-login: Jun 15 12:28:16 Panic: file ioloop.c: line 90: assertion failed: (i o->fd <= current_ioloop->highest_fd) dovecot: Jun 15 12:28:16 Error: child 17987 (login) killed with signal 6 imap-login: Jun 15 13:14:58 Panic: file ioloop.c: line 90: assertion failed: (i o->fd <= current_ioloop->highest_fd) dovecot: Jun 15 13:14:58 Error: child 13002

Per POSIX, execvp() is not safe to call in a child process forked from a multi-threaded process. We can now replace the execvp() call in the child process with a call to our fork-safe (async-signal-safe) variant. Prepare our internal execvpe context on the parent's construction path, use the context in the child, and release the context in the parent on the way out, regardless of whether the

On Wed, Feb 03, 2016 at 10:35:07AM +0100, Pino Toscano wrote: > On Tuesday 02 February 2016 19:47:12 Richard W.M. Jones wrote: > > On Tue, Feb 02, 2016 at 03:27:39PM +0100, Pino Toscano wrote: > > > diff --git a/src/launch.c b/src/launch.c > > > index f59818f..ec061e3 100644 > > > --- a/src/launch.c > > > +++ b/src/launch.c > > > @@ -418,6

On Tue, Feb 02, 2016 at 03:27:39PM +0100, Pino Toscano wrote: > Introduce an internal helper to create paths for sockets; will be useful > for changing later the logic for placing sockets. > --- > src/guestfs-internal.h | 1 + > src/launch-direct.c | 4 +++- > src/launch-libvirt.c | 10 ++++++---- > src/launch.c | 15 +++++++++++++++ > 4 files changed, 25

This hacked up version of figlet contributes a supprisingly large proportion of the Coverity issues found under xen/ (and therefore attributed against Xen) Figlet can be found in all distros, so make use of it. We keep xen.flf (being the Xen figlet font) and replace the hacked up octal transform with a short python script. The Xen Makefile has been tweaked in such a way that it still prints the

Socket activation (aka systemd socket activation) is a simple protocol that lets you pass in an opened, listening socket to a server. Supporting socket activation allows you to use a modern superserver to serve infrequent NBD requests without needing nbdkit to be running the whole time. Although the protocol was invented by systemd, it has been implemented in a few other places, and the protocol

Hi, After FreeBSD changed from using -O2 to using -O on their ARM port, I found that sshd stopped working. (gcc version 4.2.1 20070719 [FreeBSD]) I have downloaded openssh-SNAP-20080220.tar.gz and the code still look the same. Anyway looking into it, I found that the problem is in monitor_fdpass.c in the functions mm_send_fd and mm_receive_fd. Using -O2 used to align the tmp array on a 4 byte

Introduce a new read-only API to get a path where to store temporary sockets: this is different than tmpdir, as we need short paths for sockets (due to sockaddr_un::sun_path), and is either XDG_RUNTIME_DIR if set, or /tmp. Adapt guestfs_int_create_socketname to create sockets in that location, checking whether the resulting path still fits in the limited buffer. Furthermore, print sockdir and

This function was kind of like debug(), except that it didn't check the g->verbose flag and it only worked in the library (it would crash if used after fork). It also wasn't very useful. The sort of boot analysis done by tests/qemu/boot-analysis.c means that timestamping (some) messages is even less interesting than before. Remove it and replace calls with debug() instead. ---

The API for UNIX sockets limits the path to a static size (usually 104 or 108 characters, NULL included), which is internally represented as UNIX_PATH_MAX. If the temporary directory set is long enough (e.g. when running tools as uninstalled, using "run") then these socket paths get trucated, if not even cause failures when binding the sockets. Introduce a new internal API to create