similar to: CHROOT_IN and CHROOT_OUT

Resolve in the guest the given path, so absolute symlinks can be listed using appliance tools without resolution errors. Also remove the note about the possibility to escape the sysroot using ll and llz, since realpath won't return paths outside sysroot. Fixes part of RHBZ#1293276. --- daemon/ls.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) diff --git

I've attached v2v/STATUS. There's still a bit to do. I'm not yet proposing this for inclusion, just discussion. Apart from the tool itself, I think there's mileage in considering how the functionality of Sys::Guestfs::Lib could be given more structure. I think there's considerable mileage in moving much of Sys::Guestfs::Lib into Sys::Guestfs::GuestOS. I haven't tried

I'm trying to use guestmount to install some kernel modules in a guest: [mbooth at mbooth linux-2.6 (amit)]$ make modules_install INSTALL_MOD_PATH=~/etch ln: creating symbolic link `/home/mbooth/etch/lib/modules/2.6.32-rc6/source': No such file or directory make: *** [_modinst_] Error 1 I think something's screwy with symlinks. In the following, /tmp/source is a symlink, and I

Output from guestfish after upgrading to rawhide libguestfs, compiled with virtio: ><fs> add_drive "/dev/Guests/RHEL52PV32" ><fs> add_cdrom "/var/lib/virt-v2v/transfer.iso" ><fs> launch ><fs> list-devices /dev/sr0 /dev/vda Note that the order has swapped. If these aren't consistent we don't have a good way to determine which host

On Tuesday 07 January 2014 21:04:36 Richard W.M. Jones wrote: > On Tue, Jan 07, 2014 at 04:06:43PM +0100, Pino Toscano wrote: > > Hi, > > > > attached there is a prototype of patch for adding a new > > copy-attributes command. Such command would allow copy the > > attributes of a "file" to> > > another, so for example in guestfish: > >

I've attached my initial thoughts on the design for the v2v tool. -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: v2v-pseudo.txt URL:

On Tue, Dec 01, 2015 at 03:59:56PM +0100, Mateusz Guzik wrote: > CHROOT_IN/OUT around commandvf are definitely problematic. chroot should be > done in the child, which also removes the need to chroot out in the > parent. The CHROOT_IN/OUT business does need to be rewritten. Every instance where we currently do something like: CHROOT_IN; r = stat (fd, &statbuf); CHROOT_OUT

On 01/19/2012 08:43 PM, Richard W.M. Jones wrote: > I don't remember this commit coming up for review, although it seems > to have been pushed upstream: Well spotted! I was just about to point out that you did review it, when I noticed I'd mixed this one up with a similar one. You reviewed the other one. I have pushed this one accidentally. > commit

As part of a new virt-v2v feature, I've been thinking about how to write data to an arbitrary block device in the appliance. I need to be able to write arbitrary chunks of data to specific places on the device. This will need a new API, as guestfs_pread can't open a block device. While I'm at it, I'd like to create a new family of APIs which operate on a file handle: int

I've attached a patch to generator.ml for the proposed new file apis. Note that hread, hpread, hwrite and hpwrite are slightly different to the apis I proposed previously. I've also added hallocate for good measure. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 --------------

We just released virt-v2v 0.8.5, which also covers virt-p2v. This is primarily a bugfix release, with a couple of new features thrown in. The major changes are summarised below: V2V *** * Default -ic and -oc to qemu:///session or qemu:///system as appropriate depending on root. * Allow Windows conversions to succeed when firstboot.bat, rhsrvany.exe and rhev-apt.exe aren't available. *

This is a snapshot of gobject bindings. This is literally mid-edit, and contains numerous known errors in its output! I'm posting it for review of the ocaml code. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -------------- next part -------------- An embedded and charset-unspecified

I've attached the generated gobject bindings for direct review. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -------------- next part -------------- A non-text attachment was scrubbed... Name: Guestfs-1.0.gir Type: text/xml Size: 435504 bytes Desc: not available URL:

- add a flag to request chroot for the process, which is done only as very last (before chdir) operation before exec'ing the process in the child: this avoids using CHROOT_IN & CHROOT_OUT around command* invocations, and reduces the code spent in chroot mode - add failure checks for dup2 and open done in child, not proceeding to executing the process if they fail - open /dev/null

Move all the common code to a new _getxattr function, much like done for other xattrs operations. Mostly code motion, no functional changes. --- daemon/xattr.c | 54 +++++++++++------------------------------------------- 1 file changed, 11 insertions(+), 43 deletions(-) diff --git a/daemon/xattr.c b/daemon/xattr.c index abed5ff..d8ad59a 100644 --- a/daemon/xattr.c +++ b/daemon/xattr.c @@ -55,6

We've recently discovered that libguestfs can't handle guests which use md. There are (at least) 2 reasons for this: Firstly, the appliance doesn't include mdadm. Without this, md devices aren't detected during the boot process. Simply adding mdadm to the appliance package list fixes this. Secondly, md devices referenced in fstab as, e.g. /dev/md0, aren't handled

We've currently got a bug in libguestfs which means we can't inspect filesystems in btrfs subvolumes: https://bugzilla.redhat.com/show_bug.cgi?id=824021 This is the default configuration if you select btrfs in F17+. The issue is that it requires an api to fix it, as the return values of inspect_os, inspect_get_filesystems and inspect_get_mountpoints can't express a btrfs

When running commands in the mounted guest (using the "command" API, and APIs based on it), provide the /dev/null from the appliance as open fd for stdin. Commands usually assume stdin is open if they didn't close it explicitly, so this should avoid crashes or misbehavings due to that. --- daemon/command.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-)

Not useful from a testing standpoint (since this presumes a metric ton of other changes), but mostly a heads-up where I'm going. >From 62cbebffe9859046019b500e4bcdb0e44e575755 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Tue, 11 Aug 2009 17:17:08 +0200 Subject: [PATCH libguestfs] generator.ml: constify do_mkdtemp * daemon/dir.c (do_mkdtemp): Rewrite

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-