similar to: [PATCH libguestfs] fish: don't read freed memory

There's a new syntax check rule from gnulib. It requires that you write e.g., exit (EXIT_SUCCESS), not exit (0). And the same for 1/EXIT_FAILURE and any other constants. There were a lot of violations, including a few false positives, so I started with the exemptions (see the .x-sc file below). Then I converted the vast majority automatically, with this: maint: use EXIT_SUCCESS and

Lets user view journald log from VM in a similar format as journalctl uses. Fixes RFE: journal reader in guestfish (RHBZ#988100) --- fish/fish.h | 3 +++ generator/Makefile.am | 6 ++++-- generator/actions.ml | 22 ++++++++++++++++++++++ generator/main.ml | 3 +++ 4 files changed, 32 insertions(+), 2 deletions(-) diff --git a/fish/fish.h b/fish/fish.h index df22e34..8ae6454

guestfish --listen necessarily redirects its stdout to /dev/null so as not to interfere with eval. The remote protocol doesn't contain any other provision for collecting stdout for the caller, so executing guestfish --remote will never generate any output. This patch fixes that by forwarding the caller's STDOUT to the listener over the unix socket connection. The listener redirects its

Hello, I'm going to use wine to use a gps software on my carpc. The GPS software runs great but when the window loses focus it hangs until the windows gets focus back. I guess this is really a fault of the application, I assume it does the same without wine (I actually never tried it outside wine so I don't know). Anyway because it's under wine it's easy to workaround it. I want

From: "Richard W.M. Jones" <rjones at redhat.com> For a test case, see: https://bugzilla.redhat.com/show_bug.cgi?id=803533 In guestfish, we use the gnulib closeout module which sets up an atexit handler to detect if there were any errors on stdout when the program exits. This is so we can fail correctly in out of disk space cases like: guestfish [...] > output However the

On Thu, Jun 27, 2019 at 10:18:30PM -0500, Eric Blake wrote: > + /* Queue up a write command so large that we block on POLLIN, then queue > + * multiple disconnects. XXX The last one should fail. > + */ > + if (nbd_aio_pwrite (nbd, buf, 2 * 1024 * 1024, 0, 0) == -1) { > + fprintf (stderr, "%s: %s\n", argv[0], nbd_get_error ()); > + exit (EXIT_FAILURE); > +

On 6/30/19 12:54 PM, Richard W.M. Jones wrote: > On Thu, Jun 27, 2019 at 10:18:30PM -0500, Eric Blake wrote: >> + /* Queue up a write command so large that we block on POLLIN, then queue >> + * multiple disconnects. XXX The last one should fail. >> + */ >> + if (nbd_aio_pwrite (nbd, buf, 2 * 1024 * 1024, 0, 0) == -1) { >> + fprintf (stderr, "%s:

On Wed, Sep 11, 2019 at 08:48:28AM -0500, Eric Blake wrote: > On 9/11/19 5:40 AM, Richard W.M. Jones wrote: > > Very much a work in progress as there are still many tests using > > qemu-io which are candidates for conversion. > > > > You'll notice at the end of test-full.sh that the new test has some > > duplicated code which looks as if it ought to be

In order to handle reading an in-flight response while in the middle of sending a second command, we'll need a way to jump back into the middle of a command being sent. This is easier if the state that sets wbuf is distinct from the state that reads into wbuf, and if we don't move the command to the in-flight queue until after the writes finish. --- generator/generator | 14

Lets user view journald log from VM in a similar format as journalctl uses. Makes virt-log use the same code as guestfish for journal-view. Fixes RFE: journal reader in guestfish (RHBZ#988100) --- cat/Makefile.am | 1 + cat/log.c | 112 +------------------------------- fish/Makefile.am | 1 + fish/fish.h | 3 + fish/journal.c | 178

There were a few unchecked syscalls in fish.c >From ba8b8b0684a03b6e6fbb939ed7e1cbf5e1000092 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering at redhat.com> Date: Wed, 19 Aug 2009 10:01:07 +0200 Subject: [PATCH libguestfs] guestfish: detect a few more failed syscalls * fish/fish.c (issue_command): Detect/diagnose more failed syscalls. --- fish/fish.c | 26

As already noted in our state machine, a client that batches up a large read followed by large writes, coupled with a server that only processes commands in order, can result in deadlock (the server won't read more until we unblock its ability to write out its reply to our first command; but we aren't willing to read until we are done writing out our second command). Break the deadlock by

As already noted in our state machine, a client that batches up a large read followed by large writes, coupled with a server that only processes commands in order, can result in deadlock (the server won't read more until we unblock its ability to write out its reply to our first command; but we aren't willing to read until we are done writing out our second command). Break the deadlock by

Lets user view journald log from VM in a similar format as journalctl uses. Makes virt-log use the same code as guestfish for journal-view. Fixes RFE: journal reader in guestfish (RHBZ#988100) --- cat/Makefile.am | 1 + cat/log.c | 113 +------------------------------- fish/Makefile.am | 1 + fish/fish.h | 3 + fish/journal.c | 178

Per discussion on IRC, here are two changes to convert all TABs-as-indentation to spaces. The first one is the fully-automated conversion. However, note that the command mentioned uses a file (the .x-sc* one) that is added only in the following patch. The second patch adds rules to help keep things that way: Document and enforce the new spaces-only indentation policy. * cfg.mk

On Tue, May 21, 2019 at 10:25:49AM -0500, Eric Blake wrote: > On 5/21/19 10:09 AM, Eric Blake wrote: > > A generic client exploiting multiple in-flight commands should be > > prepared for out-of-order responses (and should probably ensure that > > there are no overlaps between parallel in-flight commands to avoid > > unspecified disk contents if the server acts on

Refactor logic in preparation for new APIs. Signed-off-by: Matteo Cafasso <noxdafox@gmail.com> --- daemon/tsk.c | 89 ++++++++++++++++++++++++++++++------------------------------ 1 file changed, 44 insertions(+), 45 deletions(-) diff --git a/daemon/tsk.c b/daemon/tsk.c index 6e6df6d..eb4f301 100644 --- a/daemon/tsk.c +++ b/daemon/tsk.c @@ -44,12 +44,12 @@ enum tsk_dirent_flags { static

Hi Rich, I spend several days on this issue but still cannot figure out the root cause. Sometimes, guestfs_lauch() gets stuck, sometimes, it is ok. I reproduced this issue using guestfish: -bash-4.2# guestfish Welcome to guestfish, the guest filesystem shell for editing virtual machine filesystems and disk images. Type: 'help' for help on commands 'man' to read the manual

Hi all, I'm going nuts. Ken Weiss and Steve Holstead have been very nice to me and supplied me with info on how to set my configure files and such. It helped me a lot but I still get stuck a bit later in the process. Namely during pass_check.c. I'm on a AIX 4.1.5 box. Using the export version of AFS 3.4. Help is appreciated. I wouldn't ask you all this if I hadn't already spent

--- This is what I used to provoke the deadlocks; before my patch series, it was succeeding for a fully-parallel server: nbdkit -U - memory 2M --run './deadlock $unixsocket' as well as for a serialized server that didn't trip up Linux kernel buffering limits: nbdkit -U - --filter=noparallel memory 256k --run './deadlock $unixsocket' but was reliably hanging with both client