similar to: [PATCH] build: avoid locale-specific changes in generated, VC'd file

Here's a patch series to make libguestfs use gnulib via a git submodule. The first thing I did was to look at the failures from "make syntax-check" and fix the config.h-related ones below. The others are now temporarily disabled via a variable in cfg.mk. I fixed the config-h problems and moved those change sets to precede the test-adding one, so that bisection still works, even if

This change adds an explicit dependency on generator.ml for every file it generates, except java files. Java is left for another time because it's considerably trickier. This fixes parallel make, and will automatically re-create generated files when make is run from any directory. It also fixes the problem which efad4f53 was targetting. Specifically, src/guestfs_protocol.(c|h) had an

Add a macro DUP_RESOLVE_DEVICE_OR_PATH to resolve path or device. Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com> --- daemon/daemon.h | 18 ++++++++++++++++++ daemon/mount.c | 13 ++----------- po/POTFILES | 8 ++++++++ 3 files changed, 28 insertions(+), 11 deletions(-) diff --git a/daemon/daemon.h b/daemon/daemon.h index 85eec45..39cc3f3 100644 --- a/daemon/daemon.h +++

This patch makes Perl strings translatable. The Perl strings end up in the PO files as usual. It does not touch the embedded POD. Internationalizing the Perl strings was pleasantly simple. Just add: use Locale::TextDomain 'libguestfs'; at the top of any *.pl or *.pm file. Then for each string in the file that you want to be translatable you place TWO underscores before it: -

Here are four small patches. First, I enabled all the warnings, then I fixed the newly exposed offenses, then I put the warning-enabling patch at the end, for the sake of future bisectors: [1/4] ocaml/guestfs_c.c avoid signed/unsigned-comparison warning [2/4] ocaml/guestfs_c.c: avoid warning about initialization discarding "const" [3/4] ocaml/guestfs_c.c: avoid warning about missing

This implements the structure and most of the functionality of the initial virt-v2v tool. --- perl/lib/Sys/Guestfs/GuestOS.pm | 97 ++++ perl/lib/Sys/Guestfs/GuestOS/RedHat.pm | 506 +++++++++++++++++++++ perl/lib/Sys/Guestfs/HVSource.pm | 132 ++++++ perl/lib/Sys/Guestfs/HVSource/Xen/Linux.pm | 141 ++++++ perl/lib/Sys/Guestfs/HVTarget.pm

Older GCC versions (e.g. < 4.9) may complain about inline functions that cannot be inlined (growing the generated code). It is not really a problem for us, so just suppress again the warning. Followup of commit c37c554fc56151b709882b382bb5fa26d9083449. --- m4/guestfs_c.m4 | 1 + 1 file changed, 1 insertion(+) diff --git a/m4/guestfs_c.m4 b/m4/guestfs_c.m4 index 7250294..ea26202 100644 ---

After fixing some warnings (see prior commits), we can now enable them in configure.ac. --- m4/guestfs_c.m4 | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/m4/guestfs_c.m4 b/m4/guestfs_c.m4 index e91446f..7250294 100644 --- a/m4/guestfs_c.m4 +++ b/m4/guestfs_c.m4 @@ -43,22 +43,15 @@ fi dnl This, $nw, is the list of warnings we disable. nw= nw="$nw

From: "Richard W.M. Jones" <rjones at redhat.com> --- configure.ac | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index fa97479..6e42423 100644 --- a/configure.ac +++ b/configure.ac @@ -141,6 +141,10 @@ if test "$gl_gcc_warnings" = yes; then # Work around warning in src/inspect.c. This seems to be a bug in gcc

Hi, building current git fails with gcc -std=gnu99 -std=gnu99 -I.. -I/usr/lib/ocaml -I../ocaml -I../src -I../src -g -O2 -fPIC -Wall -c guestfs_c_actions.c In file included from ../src/guestfs.h:84, from guestfs_c_actions.c:35: ../src/guestfs-actions.h:28: error: expected declaration specifiers or '...' before 'va_list' This is fixed by an #include

On Thu, Dec 05, 2013 at 07:02:28PM +0100, Pino Toscano wrote: > On Thursday 05 December 2013 15:53:58 Richard W.M. Jones wrote: > > On Thu, Dec 05, 2013 at 04:30:05PM +0100, Pino Toscano wrote: > > > Fix the dependencies of the libguestfs.pot target: other than using > > > the right make variables holding the contents of the POTFILES, > > > depend also on the

We observed a while back that the Perl-based libguestfs tools were not being localized. In fact I've tracked this problem down to a regression some time ago and some subsequent changes we made. These two patches fix everything. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many

On Thursday 05 December 2013 15:53:58 Richard W.M. Jones wrote: > On Thu, Dec 05, 2013 at 04:30:05PM +0100, Pino Toscano wrote: > > Fix the dependencies of the libguestfs.pot target: other than using > > the right make variables holding the contents of the POTFILES, > > depend also on the POTFILES themselves. > > --- > > > > po/Makefile.am | 2 +- > >

On Thu, Dec 05, 2013 at 04:30:05PM +0100, Pino Toscano wrote: > Fix the dependencies of the libguestfs.pot target: other than using the > right make variables holding the contents of the POTFILES, depend also > on the POTFILES themselves. > --- > po/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/po/Makefile.am b/po/Makefile.am >

Fix the dependencies of the libguestfs.pot target: other than using the right make variables holding the contents of the POTFILES, depend also on the POTFILES themselves. --- po/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/Makefile.am b/po/Makefile.am index b0a8038..a8343ec 100644 --- a/po/Makefile.am +++ b/po/Makefile.am @@ -65,7 +65,7 @@ XGETTEXT_ARGS = \

Reported by Nikos Skalkotos https://aur.archlinux.org/packages/libguestfs/ --- Makefile.am | 2 +- po/POTFILES | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 5defbce..663958d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -320,7 +320,7 @@ po/POTFILES: configure.ac rm -f $@ $@-t cd $(srcdir); \ find $(DIST_SUBDIRS) -name '*.c' -o

Prune from the list of sources where to extract messages various sources with no messages: - .pl and .pm files, as they do not contain messages: almost all the .pl files are tests, and the only .pm file is the Perl Sys::Guestfs module, which wraps the XS extension - dummy.c sources; they are empty sources used to build OCaml-only targets using automake - gperf generated sources - C/OCaml

Extracting separately the pot for the various languages and then creating manually the global pot (by manually joining the above ones after having stripped their headers) is wrong, since other than being an hack it can create an invalid pot when the same message appears in sources written in different languages. Instead, a cleaner and safer solution is to first let ocaml-gettext (if available)

data/Makefile.am | 8 ++--- player/swfdec-player.ui | 22 +++++++------- player/swfdec-window.c | 2 - po/POTFILES.in | 1 po/POTFILES.skip | 1 po/fr.po | 72 ++++++++++++++++++++++++++++++++---------------- thumbnailer/Makefile.am | 20 +++++-------- 7 files changed, 74 insertions(+), 52 deletions(-) New commits: commit

They do not contain messages. --- Makefile.am | 1 + po/POTFILES-ml | 11 ----------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/Makefile.am b/Makefile.am index 4dde5002..46a52ca3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -115,6 +115,7 @@ po/POTFILES-ml: configure.ac grep -v '^common/mlprogress/' | \ grep -v '^common/mlvisit/' | \ grep -v