similar to: Windows program detects debugger and quits

This fixes a NULL pointer access inside nvkm_acr_oneinit in case necessary firmware files couldn't be loaded. Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/212 Fixes: 4b569ded09fd ("drm/nouveau/acr/ga102: initial support") Signed-off-by: Karol Herbst <kherbst at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/base.c | 2 +- 1 file changed, 1

Fixes coccicheck warning: drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:103:23-30: WARNING opportunity for kmemdup drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:113:22-29: WARNING opportunity for kmemdup Fixes: 22dcda45a3d1 ("drm/nouveau/acr: implement new subdev to replace "secure boot"") Reported-by: Hulk Robot <hulkci at huawei.com> Signed-off-by: Zou Wei

In the quest to remove all stack VLA usage from the kernel[1], this allocates the working buffers before starting the writing so it won't abort in the middle. This needs an initial walk of the lists to figure out how large the buffer should be. [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA at mail.gmail.com Signed-off-by: Kees Cook <keescook at

This patch performs the following changes: 1. remove a redundant parentheses around the nvkm_acr_lsfw_add() calls 2. do assignment before this if condition, it is more readable Signed-off-by: Jing Xiangfeng <jingxiangfeng at huawei.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

gcc with W=1 reports drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: error: no previous prototype for ?wpr_generic_header_dump? [-Werror=missing-prototypes] 49 | wpr_generic_header_dump(struct nvkm_subdev *subdev, | ^~~~~~~~~~~~~~~~~~~~~~~ wpr_generic_header_dump is only used in acr.c, so it should be static Signed-off-by: Tom Rix <trix at redhat.com> ---

clang with W=1 reports drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: error: variable 'loc' set but not used [-Werror,-Wunused-but-set-variable] u32 loc, sig, cnt, *meta; ^ This variable is not used so remove it. Signed-off-by: Tom Rix <trix at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- 1 file changed, 1

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ?nvkm_acr_lsfw_load_sig_image_desc_v2?: drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ?loc? set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs <bskeggs at redhat.com> Cc: Karol Herbst <kherbst at redhat.com> Cc: Lyude Paul <lyude at

Hello linux-firmware maintainers, The following changes since commit a14150061388f4bcbf3c3499f1b12e3f0d5c0e7b: linux-firmware: Fix the filename for WsP to align with device HW_VARIANT (2016-07-08 18:07:02 -0700) are available in the git repository at: https://github.com/Gnurou/linux-firmware.git gp100 for you to fetch changes up to 777480f043ff0d955209e274127bfcd64f6e8edc: nvidia:

We accidentally set "psb" which is a no-op instead of "*psb" so it generates a static checker warning. We should probably set it before the first error return so that it's always initialized. Fixes: 923f1bd27bf1 ("drm/nouveau/secboot/gm20b: add secure boot support") Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- Static analysis. I'm

Hi all, I have lots of samba servers and want them to all authenticate against a single password file which will be a LDAP database. Where I want to be: Login to a domain called "FROST" that passes the username:passwd to a domain called "ACR" which checks LDAP. Where I'm at: I can login (from a W2K machine) to a test server called LIBIT which uses LDAP

Hi everyone, This email is to start a discussion about the format into which NVIDIA firmware is going to be provided. If you had a look at the linux-firmware branch we pushed earlier [1] you may already have an idea of the general organization, but this email is to discuss more specific details. Official firmware is organized per-chip, with an additional level of hierarchy for the different

I have this windows program; call it ACR. Its very simple I think.....though I'm not a programmer. It's an educational program and mostly involves pulling up images and documents off of a CD. I have the latest WINE from codeweavers installed. It seems to run wordpad.exe, cdplayer.exe and even the ACR installation of the disk works perfectly. The config file looks OK to me. So I

On 02/18/2016 02:54 PM, Ilia Mirkin wrote: > On Thu, Feb 18, 2016 at 12:43 AM, Alexandre Courbot <acourbot at nvidia.com> wrote: >> On 02/18/2016 02:37 PM, Ilia Mirkin wrote: >>> >>> On Thu, Feb 18, 2016 at 12:06 AM, Alexandre Courbot <acourbot at nvidia.com> >>> wrote: >>>> >>>> On 02/18/2016 12:47 PM, Ilia Mirkin wrote:

This allows to have the related MODULE_FIRMWARE tag only on relevant arch (arm64). This will saves about 400k on initramfs when not relevant Signed-off-by: Nicolas Chauvet <kwizart at gmail.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm20b.c | 2 ++ drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gp10b.c | 2 ++ 2 files changed, 4 insertions(+) diff --git

On 02/18/2016 12:47 PM, Ilia Mirkin wrote: > On Wed, Feb 17, 2016 at 10:39 PM, Alexandre Courbot <acourbot at nvidia.com> wrote: >> Hi everyone, >> >> This email is to start a discussion about the format into which NVIDIA >> firmware is going to be provided. If you had a look at the linux-firmware >> branch we pushed earlier [1] you may already have an idea

On 02/18/2016 02:37 PM, Ilia Mirkin wrote: > On Thu, Feb 18, 2016 at 12:06 AM, Alexandre Courbot <acourbot at nvidia.com> wrote: >> On 02/18/2016 12:47 PM, Ilia Mirkin wrote: >>> >>> On Wed, Feb 17, 2016 at 10:39 PM, Alexandre Courbot <acourbot at nvidia.com> >>> wrote: >>>> >>>> Hi everyone, >>>> >>>>

On Thu, Apr 30, 2020 at 12:15:28AM -0400, Ilia Mirkin wrote: > Hi Alexey, > > On Fri, Apr 24, 2020 at 10:52 PM Alexey Dobriyan <adobriyan at gmail.com> wrote: > > > > gp104 refuses to switch to "graphic" mode and show anything past > > this line: > > > > fb0: switching to nouveaufb from EFI VGA > > > > Machine is fine, as

Hi everyone, I know, it's about f**king time and I apologize for the time it took us to finally put this together. m(__)m I have pushed two git branches which enable GM200 and GM204 (GM206 to follow soon) owners to finally load NVIDIA-provided signed firmware and start GR: - https://github.com/Gnurou/linux-firmware/tree/secboot contains the signed firmware for GM200 and GM204 (they are

Hi With Kernel 5.7 I am still getting this, while booting: ~> uname -a Linux zenogentoo 5.7.0 #80 SMP Thu Jun 4 16:10:03 CEST 2020 x86_64 Intel(R) Core(TM) i7 CPU 960 @ 3.20GHz GenuineIntel GNU/Linux ~> dmesg |grep nouveau [ 0.762872] nouveau 0000:05:00.0: NVIDIA GP107 (137000a1) [ 0.875311] nouveau 0000:05:00.0: bios: version 86.07.42.00.4a [ 0.875681] nouveau 0000:05:00.0: acr:

On Fri, Jun 22, 2018 at 10:50 AM, Karol Herbst <kherbst at redhat.com> wrote: > On Thu, May 24, 2018 at 7:24 PM, Kees Cook <keescook at chromium.org> wrote: >> In the quest to remove all stack VLA usage from the kernel[1], this >> allocates the working buffers before starting the writing so it won't >> abort in the middle. This needs an initial walk of the