similar to: [nut-commits] svn commit r1334 - in trunk: . drivers

Hi all, greetings and a happy new year! I am writing as a user, rather than as an ex-developer. Usbhid-ups contains a fatal bug that was apparently introduced in r1210 (I did a binary search to find the exact revision). Arjen, you wrote "correct me if I'm wrong", so it seems that's what I am doing. ------------------------------------------------------------------------ r1210

On Jan 2, 2008 3:34 PM, Arjen de Korte <adkorte-guest at alioth.debian.org> wrote: > Author: adkorte-guest > Date: Wed Jan 2 20:34:26 2008 > New Revision: 1210 > > Log: > Parsing continues if the HID path for a report ends in 0x00000000 (these will not be made available). Commonly used as placeholders. > > It looks like (but correct me if I'm wrong) that reports

Great, thanks! Two questions: * what is a domain literal? Is this something like 192.168.0.1? In this case, the '[]' are probably unnecessary. * are you sure you want to use fprintf(stderr, ...) in a library? This doesn't seem like a good idea to me. Wouldn't it be more consistent to extend upscli_errlist[] ? -- Peter Arjen de Korte wrote: > > Author:

> Author: adkorte-guest > Date: Mon Jun 25 19:26:09 2007 > New Revision: 988 > > Log: > Update to reflect changes in the way we deal with dstate_dataok() and > dstate_datastale(). > > Historically it was needed to call dstate_dataok() regularly, to prevent > staleness warnings. This is no longer needed, now the server will PING > drivers it has not heard of

> ---------- Forwarded message ---------- > From: Arjen de Korte > To: nut-commits at lists.alioth.debian.org > Date: Mon, 27 Aug 2007 18:33:00 +0000 > Subject: svn commit r1076 - in trunk: . drivers > Author: adkorte-guest > Date: Mon Aug 27 18:33:00 2007 > New Revision: 1076 > > Log: > * drivers/libhid.[ch],libshut.[ch],libusb.[ch]: > - Cut the libshut and

> Author: adkorte-guest > Date: Fri Feb 8 07:09:51 2008 > New Revision: 1285 > > Log: > Cleanup and change the arguments to the upsdebug_hex() function so that it > no longer requires casting to an unsigned char. > > Modified: > trunk/ChangeLog > trunk/common/common.c > trunk/include/common.h > > Modified: trunk/ChangeLog I would like to do

> Author: adkorte-guest > Date: Mon Mar 10 10:08:08 2008 > New Revision: 1372 > > Log: > - allow subdrivers to override the 'shutdown.(return|stayoff)' commands > that are 'composed' in the driver > - add new 'load.(on|off).delay' commands to allow the above (will > implicitly define 'load.(on|off)' command with a delay value of

2006/11/16, Arjen de Korte <adkorte-guest@alioth.debian.org>: > Author: adkorte-guest > Date: Thu Nov 16 21:16:40 2006 > New Revision: 585 > > Modified: > trunk/ChangeLog > trunk/conf/upsd.conf.sample > trunk/server/conf.c > trunk/server/upsd.c > trunk/server/upsd.h > Log: > upsd: add MAXINIT parameter to upsd.conf to make the time upsd

On 8/10/07, Arjen de Korte <adkorte-guest at alioth.debian.org> wrote: > Author: adkorte-guest > Date: Fri Aug 10 19:16:48 2007 > New Revision: 1040 > > Log: > From the ChangeLog: [...] > - Use snprintf instead of sprintf where possible. In general, this is a good idea, but what if the resulting string is exactly sizeof(buf) ? Shouldn't it be sizeof()-1 with a

On Wed, Mar 5, 2008 at 4:44 PM, Arjen de Korte <adkorte-guest at alioth.debian.org> wrote: > Author: adkorte-guest > Date: Wed Mar 5 21:44:41 2008 > New Revision: 1358 > > Log: > - fix HAL support [Alioth Bug #304156] (backport from r1294) > - only include target specific CFLAGS and LDFLAGS only if target is actually used (backport from r1296 and r1297) > - add

Hi Arjen, in server/upsd.c r731, you moved the call conf_load() from after check_perms() (~ l.1020) to before setupsignals() (~ l.989). The problem is that conf_load() needs to open the ups driver socket, and it assumes that STATEPATH is the current working directory. The directory is only set in l.1016. Therefore, the first attempt to open a socket will always fail. From the user's point of

Citeren Arjen de Korte <adkorte-guest at alioth.debian.org>: > Author: adkorte-guest > Date: Sun Nov 16 13:00:30 2008 > New Revision: 1560 > > Log: > Generated by libtool and should not be versioned. > > Modified: > trunk/ (props changed) Right, that didn't work out quite the way I intended. Can someone please set the svn:ignore property on

On Nov 25, 2007 11:50 AM, Arjen de Korte <adkorte-guest at alioth.debian.org> wrote: > Limit detection of UPS to minimum required number of successful attempts. Flush input- and output buffers before sending any command. Can you explain the reasoning behind these changes please? The detection phase didn't stop after the minimum number of required replies to check for models that

Hi Arjen, 2007/6/21, Arjen de Korte <adkorte-guest at alioth.debian.org>: > Author: adkorte-guest > Date: Thu Jun 21 18:58:20 2007 > New Revision: 975 > > Log: > Add modem control line functions so that we don't have to mess with ioctl() calls directly. > ... excellent, I was thinking about it for some time... btw, will you also take over converting the other

2008/11/17 Arjen de Korte <adkorte-guest at alioth.debian.org>: > Author: adkorte-guest > Date: Mon Nov 17 19:34:27 2008 > New Revision: 1567 > > Log: > fix changes from r1566 that broke building > ... thanks for fixing that one ;-) SSL conditional inclusion missing? Arnaud

Citeren Arjen de Korte <adkorte-guest at alioth.debian.org>: > Author: adkorte-guest > Date: Mon Nov 24 13:13:44 2008 > New Revision: 1578 > > Log: > Use new usb_device_id_t and is_usb_device_supported() > for selection of the subdriver. Alexander, It would be nice if you could double check that I didn't horribly break something here. I don't expect any

Citeren Arjen de Korte <adkorte-guest at alioth.debian.org>: > Author: adkorte-guest > Date: Thu Jan 15 11:54:05 2009 > New Revision: 1728 > > Log: > Another stab at this. > > Modified: > trunk/tools/Makefile.am And failing miserably... :-( Can someone more fluent in 'autotoolish' fix this problem? Currently the BuildBot is broken by update r1718

On Mon, Jul 20, 2009 at 3:33 PM, Arjen de Korte<adkorte-guest at alioth.debian.org> wrote: > Author: adkorte-guest > Date: Mon Jul 20 19:33:33 2009 > New Revision: 1866 > > Log: > Resolve naming conflict Arjen, should drivers/Makefile.am be changed from: virtual_SOURCES = virtual.c to: clone_SOURCES = clone.c as well? -- - Charles Lepple

Citeren Arjen de Korte <adkorte-guest op alioth.debian.org>: > Author: adkorte-guest > Date: Sat Jan 23 10:06:51 2010 > New Revision: 2260 > > Log: > Need to define _XOPEN_SOURCE for strptime() prototype in glibc2 > > Modified: > ? ? trunk/drivers/mge-hid.c Arnaud, Apparently this solves the problem for the strptime() function, but now breaks the snprintf()

2010/12/22 Arjen de Korte <adkorte-guest at alioth.debian.org> > Author: adkorte-guest > Date: Wed Dec 22 20:31:42 2010 > New Revision: 2777 > URL: http://trac.networkupstools.org/projects/nut/changeset/2777 > > Log: > Don't version generated files > > Deleted: > trunk/scripts/hal/ups-nut-device.fdi.in > trunk/scripts/hotplug/libhid.usermap >