similar to: Re: [nut-commits] svn commit r808 - in trunk: . drivers

I think having this logic buried within libhid/libusb (libusb:libusb_open(), line 179 to 206) is ultimately a mistake, albeit one that I am probably responsible for. Would it make sense to confine libhid to low-level operations, and leave the decision of trying to reopen vs. retrying to open to the high-level driver, in this case usbhid-ups? I envision that the code in usbhid-ups:reconnect_ups()

I recently installed NUT 2.4.3 and found that the USB drivers were logging an insane amount of data to syslog: usbhid-ups | daemon debug | Apr 16 18:29:40 | libusb_get_report: No error usbhid-ups | daemon debug | Apr 16 18:29:40 | libusb_get_report: No error usbhid-ups | daemon debug | Apr 16 18:29:40 | libusb_get_report: No error usbhid-ups | daemon debug | Apr 16 18:29:40 |

Sorry about the noise guys. Below a significantly improved patch. The main difference is that all calls to usb_get_string_.. have been wrapped in a new function nut_usb_get_string()  that is implemented in libusb.c This was necessary in order to make the bufflen_fix available in libusb.c where usb_get_string() is called in libusb_open() This wrapper function mops up and hides all the work

> next_device: > + free(curDevice->Vendor); > + free(curDevice->Product); > + free(curDevice->Serial); > + free(curDevice->Bus); > usb_close(udev); > udev = NULL; > } Wouldn't it be necessary to check whether there is anything to free or not? Vendor, Product and Serial are set conditionally. In the lines upsdebugx(2, "-

Hi all, I attached a driver for MiniBox openUPS device ( http://www.mini-box.com/OpenUPS) and a dump of the hid usages. I had the possibility to make a few adjustments to the device firmware for HID usages, and although I haven't managed to produce a good structure many issues from previous firmware were at least fixed and new information added. ATM the driver only shows pertaining

Hi all, My name is Sergio Penen and I'd like to contribute to the project by developing a new driver for TS SHARA SOHO II usb ups. I'm almost done decoding the protocol and already have some basic functionality working with NUT. However I've some doubts on how to integrate this driver with NUT and I wonder if you could give me some guidance in that sense. To be more specific: In order

Change all camelcase function names to lower case in hv_mouse Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> --- drivers/staging/hv/hv_mouse.c | 92 ++++++++++++++++++++++------------------- 1

Change all camelcase function names to lower case in hv_mouse Signed-off-by: Abhishek Kane <v-abkane at microsoft.com> Signed-off-by: Hank Janssen <hjanssen at microsoft.com> Signed-off-by: Haiyang Zhang <haiyangz at microsoft.com> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com> --- drivers/staging/hv/hv_mouse.c | 92 ++++++++++++++++++++++------------------- 1

I doesn't fix any problems but I think it is nicer code. :-) I don't think we want to call usb_detach_kernel_driver_np unless we claimed the device. $ diff -uw libusb.c.bak libusb.c.new --- libusb.c.bak 2010-05-11 09:35:39.000000000 -0400 +++ libusb.c.new 2010-05-11 09:32:44.000000000 -0400 @@ -206,18 +206,21 @@ upsdebugx(2, "failed to

Hi All, I've finally found solutions for my previous problems. But since this includes changes in the shared files, I'd like to discuss them here. 1. Driver restart problem. When I start the driver for the first time, everything is ok. But when I want to restart it, problems begin. The driver fails to read Report descriptor for the second time (libusb_open is used to open the device).

Hi Peter, I've forwarded your mail to upsdev as it will be of interest for several people that are working on it. As I'm also on vacation (again) for a week and 1/2 as of this evening, I don't think I'll have the time for it before I get back.... I've not yet audited the patches, but these are queued on the Alioth tracker:

> Author: aquette > Date: Thu Jun 21 07:43:46 2007 > New Revision: 971 > > Log: > fix communication lost status handling > > Modified: > trunk/ChangeLog > trunk/drivers/usbhid-ups.c > > Modified: trunk/ChangeLog > ============================================================================== > --- trunk/ChangeLog (original) > +++ trunk/ChangeLog

Some UPSes contain HID report descriptors that fail to correctly describe the contents of reports. For example, the OpenUPS descriptor fails to set the units, logical maximum and logical minimum before the corresponding `main item' as required by the HID specification. This commit allows an override HID report descriptor to be given to usbhid-ups which replaces the one produced by the UPS,

Thanks to the great help here, I now have a UPS spitting out something resembling a report descriptor. So since I seem destined to have to create a new USB HID subdriver, I figured I'd get started on the path. I followed all of the directions on the web....I used the script to generate the usbhid subdriver, feeding it the output of the usbhid-ups driver from reading my UPS. All that worked

On 1/23/07, Henning Brauer <hb-nut@bsws.de> wrote: > good new first: the megatec driverin 2.0.5 now works with the Online > Xanto S3000R here - well, for the very basics. > > the UPS has NO way ofidentifying itself. It also does not respond to > the power ratings query ("F"). I previously used a hacked up fentonups > driver. This means the driver cannot figure out

Peter, I have been doing some more testing and I find that if I modify the libusb.c file to set a report size in libusb_get_report to 16 the error messages go away. This is the code as it currently stands: static int libusb_get_report(usb_dev_handle *udev, int ReportId, unsigned char *raw_buf, int ReportSize ) { int ReportSize_test = 16; unsigned char raw_buf_test[ReportSize_test +

I have checked in a cleaned-up version of patch #302111 (Belkin support) into CVS. See cvs diff -uN -r before_PSE_2 -r after_PSE_2 to check the difference. Here is the CHANGES entry: Tue Sep 13 20:50:14 UTC 2005 / Peter Selinger <selinger@users.sourceforge.net> - newhidups: added Belkin support. Also added some new variables and instant commands (some of these were already used by

Hello, I have been trying to get a TrippLite Internet Office 750 UPS to talk to my Linux PBX for a couple of evenings now and I'm getting nowhere... I tried searching the list archives before posting here (I'm sure I'm not the first one to try to get this going) but they seem to be offline... The UPS is unfortunately USB based but I thought I'd give it a try anyway. Here is

I tested your fix (newhidups -DDD /dev/null) using both and APC Back-UPS 350 an APC Smart-UPS RT 2000 XL. No more segmentation fault due to the fixed-size array. ~Jacob -----Original Message----- From: nut-upsdev-bounces@lists.alioth.debian.org [mailto:nut-upsdev-bounces@lists.alioth.debian.org] On Behalf Of Peter Selinger Sent: Monday, October 16, 2006 12:12 PM To: Schmier, Jacob Cc: NUT

In order to get the Oneac UPS (models ON700XAU, ON1000XAU, ON1500XAU) to work with NUT, I had to make a few minor modifications to the oneac driver. I've attached a patch with all the modifications. I tried to ensure that my modifications would not break any existing functionality, but I could not be sure without a legacy Oneac UPS to test against. In my investigation, I found out that the