similar to: ACR Anonymous Call Rejection

This fixes a NULL pointer access inside nvkm_acr_oneinit in case necessary firmware files couldn't be loaded. Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/212 Fixes: 4b569ded09fd ("drm/nouveau/acr/ga102: initial support") Signed-off-by: Karol Herbst <kherbst at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/base.c | 2 +- 1 file changed, 1

This patch performs the following changes: 1. remove a redundant parentheses around the nvkm_acr_lsfw_add() calls 2. do assignment before this if condition, it is more readable Signed-off-by: Jing Xiangfeng <jingxiangfeng at huawei.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

gcc with W=1 reports drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: error: no previous prototype for ?wpr_generic_header_dump? [-Werror=missing-prototypes] 49 | wpr_generic_header_dump(struct nvkm_subdev *subdev, | ^~~~~~~~~~~~~~~~~~~~~~~ wpr_generic_header_dump is only used in acr.c, so it should be static Signed-off-by: Tom Rix <trix at redhat.com> ---

Fixes coccicheck warning: drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:103:23-30: WARNING opportunity for kmemdup drivers/gpu/drm/nouveau/nvkm/subdev/acr/hsfw.c:113:22-29: WARNING opportunity for kmemdup Fixes: 22dcda45a3d1 ("drm/nouveau/acr: implement new subdev to replace "secure boot"") Reported-by: Hulk Robot <hulkci at huawei.com> Signed-off-by: Zou Wei

clang with W=1 reports drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:7: error: variable 'loc' set but not used [-Werror,-Wunused-but-set-variable] u32 loc, sig, cnt, *meta; ^ This variable is not used so remove it. Signed-off-by: Tom Rix <trix at redhat.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- 1 file changed, 1

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c: In function ?nvkm_acr_lsfw_load_sig_image_desc_v2?: drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c:221:21: warning: variable ?loc? set but not used [-Wunused-but-set-variable] Cc: Ben Skeggs <bskeggs at redhat.com> Cc: Karol Herbst <kherbst at redhat.com> Cc: Lyude Paul <lyude at

In the quest to remove all stack VLA usage from the kernel[1], this allocates the working buffers before starting the writing so it won't abort in the middle. This needs an initial walk of the lists to figure out how large the buffer should be. [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA at mail.gmail.com Signed-off-by: Kees Cook <keescook at

Hi With Kernel 5.7 I am still getting this, while booting: ~> uname -a Linux zenogentoo 5.7.0 #80 SMP Thu Jun 4 16:10:03 CEST 2020 x86_64 Intel(R) Core(TM) i7 CPU 960 @ 3.20GHz GenuineIntel GNU/Linux ~> dmesg |grep nouveau [ 0.762872] nouveau 0000:05:00.0: NVIDIA GP107 (137000a1) [ 0.875311] nouveau 0000:05:00.0: bios: version 86.07.42.00.4a [ 0.875681] nouveau 0000:05:00.0: acr:

In case memory resources for *bl_desc* were allocated, release them before return. Addresses-Coverity-ID: 1472021 ("Resource leak") Fixes: 0d466901552a ("drm/nouveau/secboot/acr: Remove VLA usage") Signed-off-by: Gustavo A. R. Silva <gustavo at embeddedor.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/secboot/acr_r352.c | 1 + 1 file changed, 1 insertion(+) diff --git

On Fri, Jun 22, 2018 at 10:50 AM, Karol Herbst <kherbst at redhat.com> wrote: > On Thu, May 24, 2018 at 7:24 PM, Kees Cook <keescook at chromium.org> wrote: >> In the quest to remove all stack VLA usage from the kernel[1], this >> allocates the working buffers before starting the writing so it won't >> abort in the middle. This needs an initial walk of the

Ben -- probably the ACR changes in 5.6 don't fall back nicely anymore when there's no firmware? The load shouldn't be failed, just GR disabled... Zeno -- if you grab linux-firmware, it should be all better. Not sure if you're missing it on purpose or by accident. Cheers, -ilia On Fri, Apr 3, 2020 at 11:07 AM Zeno Davatz <zdavatz at gmail.com> wrote: > > Hi >

On 8/2/18 12:51 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping! Who can take this? > > Thanks > -- > Gustavo > > On 07/24/2018 08:27 AM, Gustavo A. R. Silva wrote: >> In case memory resources for *bl_desc* were allocated, release >> them before return. >> >> Addresses-Coverity-ID: 1472021 ("Resource leak") >> Fixes:

Hi After installing Kernel 5.6 I am getting this error: Cannot run in framebuffer mode. Please specify busIDs for all framebuffer devices [ 0.757317] nouveau 0000:05:00.0: NVIDIA GP107 (137000a1) [ 0.869775] nouveau 0000:05:00.0: bios: version 86.07.42.00.4a [ 0.870157] nouveau 0000:05:00.0: acr: failed to load firmware [ 0.870256] nouveau 0000:05:00.0: acr: failed to load firmware [ 0.870356]

I have this windows program; call it ACR. Its very simple I think.....though I'm not a programmer. It's an educational program and mostly involves pulling up images and documents off of a CD. I have the latest WINE from codeweavers installed. It seems to run wordpad.exe, cdplayer.exe and even the ACR installation of the disk works perfectly. The config file looks OK to me. So I

Is it possible to have a different verbose level full log than to console output? I'd like to keep console verbose at 1, but now full log is at 1 also. Bart -------------- next part -------------- A non-text attachment was scrubbed... Name: bhfisher.vcf Type: text/x-vcard Size: 253 bytes Desc: not available Url :

On Fri, Apr 3, 2020 at 1:21 PM Zeno Davatz <zdavatz at gmail.com> wrote: > > On Fri, Apr 3, 2020 at 6:59 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote: > > > > Ben -- probably the ACR changes in 5.6 don't fall back nicely anymore > > when there's no firmware? The load shouldn't be failed, just GR > > disabled... > > > > Zeno -- if

> I'm going blind searching - maybe you know? > > During the execution of a script I want to play fake ring to caller. > Both of these examples complain of missing option: > > $agi->exec("Ringing"); > $agi->exec("Playtones ring"); > > Notice: Undefined variable: options in > /var/lib/asterisk/agi-bin/includes/phpagi.php on line 326

On Thu, May 24, 2018 at 7:24 PM, Kees Cook <keescook at chromium.org> wrote: > In the quest to remove all stack VLA usage from the kernel[1], this > allocates the working buffers before starting the writing so it won't > abort in the middle. This needs an initial walk of the lists to figure > out how large the buffer should be. > > [1]

On Fri, Apr 3, 2020 at 1:59 PM Zeno Davatz <zdavatz at gmail.com> wrote: > > On Fri, Apr 3, 2020 at 7:23 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote: > > > > On Fri, Apr 3, 2020 at 1:21 PM Zeno Davatz <zdavatz at gmail.com> wrote: > > > > > > On Fri, Apr 3, 2020 at 6:59 PM Ilia Mirkin <imirkin at alum.mit.edu> wrote: > > >

The local variable loc in nvkm_acr_lsfw_load_sig_image_desc_v2() is set but not used. Remove the variable and related code. Signed-off-by: Bo Liu <liubo03 at inspur.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c b/drivers/gpu/drm/nouveau/nvkm/subdev/acr/lsfw.c index