On Sun, 2017-01-29 at 22:43 +0000, Rowland Penny via samba wrote:> On Sun, 29 Jan 2017 17:07:39 -0500 > Sonic <sonicsmith at gmail.com> wrote: > > > On Sun, Jan 29, 2017 at 4:54 PM, Rowland Penny <rpenny at samba.org> > > wrote: > > > > > When you built Samba, did you use the '--with-ntvfs-fileserver' > > > or > > > '--enable-selftest' options with configure ? > > > > > > > I used '--without-ntvfs-fileserver'. > > OK, this is the code that is producing the error:Thanks for the analysis! I think the attached should fix it. I've filed a bug for it so we get it into 4.6. Andrew Bartlett -- Andrew Bartlett http://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-samba-tool-Correct-handling-of-default-value-for-use.patch Type: text/x-patch Size: 3071 bytes Desc: not available URL: <http://lists.samba.org/pipermail/samba/attachments/20170130/9b383110/0001-samba-tool-Correct-handling-of-default-value-for-use.bin>
On Mon, 30 Jan 2017 15:44:15 +1300 Andrew Bartlett <abartlet at samba.org> wrote:> On Sun, 2017-01-29 at 22:43 +0000, Rowland Penny via samba wrote: > > On Sun, 29 Jan 2017 17:07:39 -0500 > > Sonic <sonicsmith at gmail.com> wrote: > > > > > On Sun, Jan 29, 2017 at 4:54 PM, Rowland Penny <rpenny at samba.org> > > > wrote: > > > > > > > When you built Samba, did you use the '--with-ntvfs-fileserver' > > > > or > > > > '--enable-selftest' options with configure ? > > > > > > > > > > I used '--without-ntvfs-fileserver'. > > > > OK, this is the code that is producing the error: > > Thanks for the analysis! > > I think the attached should fix it. I've filed a bug for it so we get > it into 4.6. > > Andrew Bartlett >Sorry Andrew, but I don't think it will ;-) Unless you have built ntvfs, the '--use-xattrs' option doesn't get set until the 'def' and there it gets set to 'use_xattrs=None' along with 'use_ntvfs=False' So, by my reading, with your patch the OP is still going to get the error message. Rowland
On Mon, 2017-01-30 at 08:42 +0000, Rowland Penny wrote:> On Mon, 30 Jan 2017 15:44:15 +1300 > Andrew Bartlett <abartlet at samba.org> wrote: > > > On Sun, 2017-01-29 at 22:43 +0000, Rowland Penny via samba wrote: > > > On Sun, 29 Jan 2017 17:07:39 -0500 > > > Sonic <sonicsmith at gmail.com> wrote: > > > > > > > On Sun, Jan 29, 2017 at 4:54 PM, Rowland Penny <rpenny at samba.or > > > > g> > > > > wrote: > > > > > > > > > When you built Samba, did you use the '--with-ntvfs- > > > > > fileserver' > > > > > or > > > > > '--enable-selftest' options with configure ? > > > > > > > > > > > > > I used '--without-ntvfs-fileserver'. > > > > > > OK, this is the code that is producing the error: > > > > Thanks for the analysis! > > > > I think the attached should fix it. I've filed a bug for it so we > > get > > it into 4.6. > > > > Andrew Bartlett > > > > Sorry Andrew, but I don't think it will ;-) > > Unless you have built ntvfs, the '--use-xattrs' option doesn't get > set > until the 'def' and there it gets set to 'use_xattrs=None' along > with > 'use_ntvfs=False' > > So, by my reading, with your patch the OP is still going to get the > error message.Rowland, I'm a little confused, because I do change the defaults in the function declaration (the 'def' as you put it). I also tested it. Please look again at the changes for 'use_xattrs="auto"' Thanks, Andrew Bartlett -- Andrew Bartlett http://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
On Sun, Jan 29, 2017 at 9:44 PM, Andrew Bartlett <abartlet at samba.org> wrote:> I think the attached should fix it. I've filed a bug for it so we get > it into 4.6.Maybe a regression. Same failure in both 4-6-stable and 4-6-test, but 4-5-test works (current git). Although I do get some strange output with the classicupgrade. Many of these: ... idmap range not specified for domain '*' idmap range not specified for domain '*' idmap range not specified for domain '*' ... The original smb.conf does have: idmap config * : range = 1000000-1999999 Although it was just a PDC - winbind was not running on it. Chris
On Wed, 1 Feb 2017 18:31:16 -0500 Sonic <sonicsmith at gmail.com> wrote:> On Sun, Jan 29, 2017 at 9:44 PM, Andrew Bartlett <abartlet at samba.org> > wrote: > > I think the attached should fix it. I've filed a bug for it so we > > get it into 4.6. > > Maybe a regression. Same failure in both 4-6-stable and 4-6-test, but > 4-5-test works (current git).Definitely a regression, somebody stopped the ntvfs server being used unless it was actually built, but missed something.> Although I do get some strange output with the classicupgrade. > Many of these: > ... > idmap range not specified for domain '*' > idmap range not specified for domain '*' > idmap range not specified for domain '*'That is an artifact of not allowing the 'idmap config' lines in a Samba AD DC smb.conf any more, you can stop them by adding/changing 'log level = 0' to the smb.conf I think the debug level needs raising. Rowland