Stuart Haas
2002-Mar-15 12:24 UTC
[Samba] W2K and XP Offline files stopped working with 2.2.3a
Hi - It appears that Samba 2.2.3a broke Windows ability to use offline files from a Samba share. This used to work fine under 2.2.2. When a user syncs an offline folder, everything appears to work properly, but once disconnected, only a small portion of the files are visible in the offline folder, and the files are not accessible - they give strange error messages about files being read-only or encrypted. The same machines can synchronize files with a Windows 2K server with no problems. We have been able to reproduce this problem with clean Windows 2000 and XP installs. I have not had a chance to try an older version of Samba, but we have been using current version of Samba with no problem for a year now. Anyone else seen this problem? Any suggestions? I've got quite a few angry laptop users out there. Stuart This email has been scanned for all viruses by the MessageLabs SkyScan service. http://www.messagelabs.com/
Jeremy Allison
2002-Mar-15 13:04 UTC
[Samba] W2K and XP Offline files stopped working with 2.2.3a
On Fri, Mar 15, 2002 at 03:23:05PM -0500, Stuart Haas wrote:> Hi - > > It appears that Samba 2.2.3a broke Windows ability to use offline files from > a Samba share. This used to work fine under 2.2.2. When a user syncs an > offline folder, everything appears to work properly, but once disconnected, > only a small portion of the files are visible in the offline folder, and the > files are not accessible - they give strange error messages about files > being read-only or encrypted. The same machines can synchronize files with a > Windows 2K server with no problems. > > We have been able to reproduce this problem with clean Windows 2000 and XP > installs. I have not had a chance to try an older version of Samba, but we > have been using current version of Samba with no problem for a year now. > > Anyone else seen this problem? Any suggestions? I've got quite a few angry > laptop users out there.I posted the fix for this (it's already in SAMBA_2_2 CVS and HEAD) as a small patch a few weeks ago. Here it is again. Sorry for the bug, Jeremy. --- smbd/nttrans.c.orig Wed Feb 27 12:34:12 2002 +++ smbd/nttrans.c Wed Feb 27 12:34:58 2002 @@ -909,8 +909,8 @@ if(oplock_request && EXCLUSIVE_OPLOCK_TYPE(fsp->oplock_type)) smb_action |= EXTENDED_OPLOCK_GRANTED; -#if 1 /* JRATEST */ - /* W2K sends back 42 words here ! */ +#if 0 + /* W2K sends back 42 words here ! If we do the same it breaks offline sync. Go figure... ? +JRA. */ set_message(outbuf,42,0,True); #else set_message(outbuf,34,0,True);