rake db:schema:dumper issues

Gerardo Santana
2007-10-28T04:38:51Z

In file
http://svn.rubyonrails.org/rails/trunk/activerecord/lib/active_record/schema_dumper.rb
in method SchemaDumper#table
there are these three lines:

[snip]
          column_specs = columns.map do |column|
            raise StandardError, "Unknown type
''#{column.sql_type}''
for column ''#{column.name}''" if @types[column.type].nil?
            next if column.name == pk
[snip]


Shouldn''t it test for column.name == pk before
@types[column.type].nil?
column.type is nil for primary keys as far as I can see in the
connection adapters (its value is got from
ConnectionAdapters::Column.simplified_type).


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Ruby on Rails: Talk" group.
To post to this group, send email to
rubyonrails-talk-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
To unsubscribe from this group, send email to
rubyonrails-talk-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
For more options, visit this group at
http://groups.google.com/group/rubyonrails-talk?hl=en
-~----------~----~----~----~------~----~------~--~---