I love this library! (Not going to jump on Oprah''s couch about it though...) I''m going through the file line-by-line while reading the api docs and noticed the following lines: if (!Object.keys({ toString: true }).length) properties.push("toString", "valueOf"); Am I correct in thinking that this is a no-op? Seems to me that Object.keys({ toString: true}) will always return [ toString]. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
On Jan 22, 12:49 pm, Randy <drran...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:> Am I correct in thinking that this is a no-op? Seems to me that > Object.keys({ toString: true}) will always return [ toString].Not in IE. The "toString" property is never enumerated, even when it''s specified by the user. Yes, this is a bug. Cheers, Andrew --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
On Jan 22, 2008 11:43 AM, Andrew Dupont <google-TiabPMV39B5K4mp1Ns0Z8Q@public.gmane.org> wrote:> > > On Jan 22, 12:49pm, Randy <drran...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > Am I correct in thinking that this is a no-op? Seems to me that > > Object.keys({ toString: true}) will always return [ toString]. > > Not in IE. The "toString" property is never enumerated, even when it''s > specified by the user. Yes, this is a bug.Ah yes... If it looks weird, IE must be at the bottom of it. Thanks! --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---
On Jan 23, 5:43 am, Andrew Dupont <goo...-TiabPMV39B5K4mp1Ns0Z8Q@public.gmane.org> wrote:> On Jan 22, 12:49 pm, Randy <drran...-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > > > Am I correct in thinking that this is a no-op? Seems to me that > > Object.keys({ toString: true}) will always return [ toString]. > > Not in IE. The "toString" property is never enumerated, even when it''s > specified by the user. Yes, this is a bug.The result of the above is that in IE, the toString and valueOf methods of the object passed to the addMethods function will be added to the "Class", even if they aren''t enumerable. That may have unexpected results (in IE). -- Rob --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Ruby on Rails: Spinoffs" group. To post to this group, send email to rubyonrails-spinoffs-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To unsubscribe from this group, send email to rubyonrails-spinoffs-unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org For more options, visit this group at http://groups.google.com/group/rubyonrails-spinoffs?hl=en -~----------~----~----~----~------~----~------~--~---