RE: Next script.aculo.us release, help needed

Gregory Hill
Tue, 20 Jun 2006 16:28:51 -0000

Not so much Scriptaculous, but I posted a fix for prototype.js, which as
broken the Element.cleanWhitespace in IE when they added the
Element.extend functionality.  Here''s the email I sent a while back
(this fix has an added benefit of improving performance for
Element.cleanWhitespace):

Marco and I have been emailing about this and I finally found the fix,
so here it is.  Feel free to pass it along to Sam, if he even responds
to bug reports any more:

In prototype.js, change line 998 From:
        Element.remove(node);
To:
        node.parentNode.removeChild(node);

Element.remove calls $(), which calls Element.extend.  In
Element.extend, when it says element._extended = true;, it dies in IE on
text nodes (element.nodeType == 3).  Since we don''t really care to
extend the node just to remove it, we should not even care about
appending all of the extra functions to the node.  Another option is to
put a conditional in $() that just returns the element if it has a
nodeType of 3, but I suppose there might be some weird case where you
actually want to add extra functions to text nodes (I can''t think of
any
at the moment, though).

Any chance you can make sure Sam gets this included in Prototype? (maybe
he already has?)

Greg


> -----Original Message-----
> From:
rails-spinoffs-bounces-1W37MKcQCpIf0INCOvqR/iCwEArCW2h5@public.gmane.org
[mailto:rails-spinoffs-
> bounces-1W37MKcQCpIf0INCOvqR/iCwEArCW2h5@public.gmane.org] On Behalf Of
Thomas Fuchs
> Sent: Tuesday, June 20, 2006 4:48 AM
> To: script.aculo.us List
> Subject: [Rails-spinoffs] Next script.aculo.us release, help needed
>
> Hey there!
>
> I''m in the process of looking through the various bug reports and
> tickets and
> fixing script.aculo.us as I go along.
>
> As I want a 1.6.2 bugfix release to happen this week, please help me
> out with:
> - Looking throught the open bugs list on the trac, testing stuff and
> giving helpful comments (like "+1")
> - Identifiying what bugs/patches should be included (answer to this
> post, please!)
> - Providing patches and tests where needed
>
> Here''s the URL to the bug list:
> http://dev.rubyonrails.org/query?
> status=new&component=script.aculo.us&type=defect&order=priority
>
> Since 1.6.1, following patches/changes have made it to trunk:
>
> * Fix only option in onEmptyHover, fiex #5348 [thx glenn nilsson]
> * Fix Effect.BlindDown and SwitchOff handling of supplied callbacks,
> fixes #5089 [thx martinstrom]
> * Fix a problem with field focus on Ajax.InPlaceEditor and loading
> external text, fixes #4988, #5244 [thx rob]
> * Do not attempt to scroll if scrollspeed is 0/0, fixes #5035 [thx
tomg]
> * Fix a problem with Sortable Tree serialization, fixes #4939, #4688,
> #4767  [thx Sammi Williams]
> * Fix an endless loop with sliders, fixes #3226, #4051, #4765 [thx
jeff]
> * Make autocompleter work with update DIVs that have scrollbars,
> fixes #4782 [thx Tommy Skaue]
> * Corrected options parsing on switchoff effect, fixes #4710 [thx
> haldini]
>
> So, please, please, please with sugar on the top help me, the more
> people
> do the faster the next release will be out there! :)
>
> Thanks,
> Thomas