I found some bugs in the latest beta4 rails.js and noticed an almost completely rewritten version is in edge at the moment... http://github.com/rails/rails/commit/f61d923d284062b4e4864d81c603157020198d06 This version uses document.on and doesn''t appear to be compatible with prototype 1.6.1. Am I missing something obvious here as to why this new version doesn''t work with the rest of my beta4 js files? Thanks -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Tue, Jul 13, 2010 at 08:21, Andrew Kaspick <akaspick@gmail.com> wrote:> > This version uses document.on and doesn''t appear to be compatible with > prototype 1.6.1.Yes, Rails 3 makes heavy use of new event delegation features in Prototype 1.7.> Am I missing something obvious here as to why this > new version doesn''t work with the rest of my beta4 js files?Not sure what the question is. Have you copied edge rails.js to your project, updated Prototype, and found out the javascript breaks? -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
I updated rails.js, but did not update prototype.js. The copy of prototype in edge says it''s still 1.6.1, so I didn''t update anything else... http://github.com/rails/rails/blob/f61d923d284062b4e4864d81c603157020198d06/railties/lib/rails/generators/rails/app/templates/public/javascripts/prototype.js If the edge version is 1.6.1 and rails.js depends on 1.7 shouldn''t 1.7 be in edge instead then? On Tue, Jul 13, 2010 at 4:50 AM, Mislav Marohnić <mislav.marohnic@gmail.com> wrote:> On Tue, Jul 13, 2010 at 08:21, Andrew Kaspick <akaspick@gmail.com> wrote: >> >> This version uses document.on and doesn''t appear to be compatible with >> prototype 1.6.1. > > Yes, Rails 3 makes heavy use of new event delegation features in Prototype > 1.7. > >> >> Am I missing something obvious here as to why this >> new version doesn''t work with the rest of my beta4 js files? > > Not sure what the question is. Have you copied edge rails.js to your > project, updated Prototype, and found out the javascript breaks? > > -- > You received this message because you are subscribed to the Google Groups > "Ruby on Rails: Core" group. > To post to this group, send email to rubyonrails-core@googlegroups.com. > To unsubscribe from this group, send email to > rubyonrails-core+unsubscribe@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/rubyonrails-core?hl=en. >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
Ticket created at https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5109-make-prototypejs-compatible-with-railsjs-for-30 Upgrades prototype.js to be compatible with rails.js On Tue, Jul 13, 2010 at 5:20 AM, Andrew Kaspick <akaspick@gmail.com> wrote:> I updated rails.js, but did not update prototype.js. > > The copy of prototype in edge says it''s still 1.6.1, so I didn''t > update anything else... > http://github.com/rails/rails/blob/f61d923d284062b4e4864d81c603157020198d06/railties/lib/rails/generators/rails/app/templates/public/javascripts/prototype.js > > If the edge version is 1.6.1 and rails.js depends on 1.7 shouldn''t 1.7 > be in edge instead then? > > On Tue, Jul 13, 2010 at 4:50 AM, Mislav Marohnić > <mislav.marohnic@gmail.com> wrote: >> On Tue, Jul 13, 2010 at 08:21, Andrew Kaspick <akaspick@gmail.com> wrote: >>> >>> This version uses document.on and doesn''t appear to be compatible with >>> prototype 1.6.1. >> >> Yes, Rails 3 makes heavy use of new event delegation features in Prototype >> 1.7. >> >>> >>> Am I missing something obvious here as to why this >>> new version doesn''t work with the rest of my beta4 js files? >> >> Not sure what the question is. Have you copied edge rails.js to your >> project, updated Prototype, and found out the javascript breaks? >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Ruby on Rails: Core" group. >> To post to this group, send email to rubyonrails-core@googlegroups.com. >> To unsubscribe from this group, send email to >> rubyonrails-core+unsubscribe@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/rubyonrails-core?hl=en. >> >-- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.
On Wed, Jul 14, 2010 at 5:03 AM, Andrew Kaspick <akaspick@gmail.com> wrote:> Ticket created at > https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/5109-make-prototypejs-compatible-with-railsjs-for-30 > > Upgrades prototype.js to be compatible with rails.jsExcellent it is up, thank you! -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscribe@googlegroups.com. For more options, visit this group at http://groups.google.com/group/rubyonrails-core?hl=en.