Re: Limiting test assertion methods in Core

Geoff B
Fri, 13 Jul 2007 08:15:42 -0000

If the goal is to keep the API streamlined, #8793 (assert_charset)
probably isn''t a big enough win to bother with. But #8791
(assert_content_type) does allow you to do this:

assert_content_type :js

instead of this:

assert_equal Mime::Type.lookup_by_extension(''js'').to_s,
@response.content_type

On Jul 12, 10:52 pm, "Marcel Molina Jr." <mar...@vernix.org>
wrote:
> On Thu, Jul 12, 2007 at 07:57:01PM -0700, Josh Peek wrote:
> > There used to be a ton of test assertion helpers in Core like
> > assert_session, assert_cookie, assert_flash, etc. See
>
>http://dev.rubyonrails.org/browser/trunk/actionpack/lib/action_contro...
> > for some history. I wasn''t around for the extract reason they
were
> > removed, but we don''t need a helper method for every possible
> > situation in Rails. And assert @response.flash[:notice] isn''t
that
> > bad.
>
> They were pulled out because the API was bloated. Providing access to
> sessions and flash and cookies in functional tests removed the need for
> almost 30 assertions.
>
> marcel
> --
> Marcel Molina Jr. <mar...@vernix.org>