[Puppet Users] Re: Pluginsync in 0.25

DerekW
2009-05-13T08:59:51Z

Cool.

So the undefined behaviour you''re talking about.  I can reliably
invoke said undefined behaviour, and it _is_ undefined differently to
0.24.4.  Or it could be the same and just tickled by the pluginsync
issue.

Let me explain in plain English...

I''m using /var/lib/puppet/plugins for everything - $pluginpath,
$plugindest, $libdir.  That way when I use our internal Makefile
system to make install onto a Puppetmaster it''s in the right place,
it''s exported via the fileserver, and when the client does a
pluginsync it goes to the same place.  All our config files are as
similar as possible.

I''m provoking the cleanout issue by doing a puppetd --pluginsync on
the Puppet Master host.  With 0.23 and 0.24 I''ve have no issue - the
files are not removed.  With 0.25.0 beta I see it recursively empties
$plugindest because $pluginsource is delivering nothing.

I''ll raise a ticket as soon as Redmine starts working :)  You can
decide what the right thing is.

Cheers,
Derek


On May 12, 9:48 pm, Luke Kanies <l...@madstop.com>
wrote:
> On May 12, 2009, at 5:35 AM, DerekW wrote:
>
>
>
> > I''ve been testing 0.25beta1.  I understand that the default
pluginsync
> > mount is now a special PluginMount, presumably to do with the fact
> > that plugins are now modular.
>
> There was actually a special PluginMount class before; it was just in
> the same file as the main Mount class (as was all of the fileserving
> code, actually).
>
>
>
> > However, I haven''t quite gotten around to refactoring my
Manifest, and
> > moreover a lot of our custom types and functions are actually shared
> > amongst modules anyway.
>
> > Is the new model to assign my custom types to an arbitrary module (say
> > the one where it''s used most) and rely on that?
>
> The behaviour shouldn''t have changed at all; only the internals.
 Any
> changes in function are bugs (so we appreciate the testing).
>
>
>
> > I can''t get this to work with non-modular plugins (see ticket
#2244).
> > At the moment I just created a fileserver export called
"oldplugins"
> > and set my client
> > pluginsource = puppet:///oldplugins/
>
> > That doesn''t appear to be loading my types so the run fails
but I''ve
> > raised ticket #2245for that.
>
> I''ve got both of those in my queue and I hope to get to them this
week.
>
>
>
> > I''m also seeing my /var/lib/puppet/plugins dir completely
cleaned out
> > on the Puppetmaster (!) and I''m trying to track that down
too.  I do
> > wonder if puppetmasted is trying to create a combined directory from
> > each of my modules for fileserving purposes?
>
> If your pluginsource and plugindest are the same directory, I would
> consider behaviour to be somewhat undefined.  I mean, it *should*
> work, but...
>
> --
> Always behave like a duck - keep calm and unruffled on the surface but
> paddle like the devil underneath. -- Jacob Braude
> ---------------------------------------------------------------------
> Luke Kanies |http://reductivelabs.com|http://madstop.com