Re: 0.24.1 puppetmaster skips new config with syntax errors?

Mark Plaksin
Tue, 12 Feb 2008 21:28:51 -0000

Luke Kanies <luke@madstop.com> writes:

> On Feb 12, 2008, at 11:27 AM, Mark Plaksin wrote:
>
>> Is puppetmaster supposed to ignore manifest changes when those changes
>> include syntax errors?  And then it does notice when I restart
>> puppetmaster?  That''s what seems to be happening to me.
>>
>> For example, if I put a syntax error in my.pp and then test a client
>> against the the master I get no complaints.  If I restart puppetmaster
>> and retest the client says "Ack!  Syntax error!".
>>
>> I could sort of see this being a feature--puppetmaster refuses to
>> acknowledge new configs that have syntax errors.  But since it *does*
>> notice on restart it''s possible to have syntax errors waiting
to bite
>> you.
>>
>> (I finally have a pre-commit hook in place so I shouldn''t run
into
>> this
>> situation any more :)
>>
>> This is with 0.24.1 client and server both running on RHEL 5.
>
> It should definitely notice syntax errors and at least log them.  I
> think I noticed the same thing but I couldn''t track it down; it
would
> make sense that the errors are only when reparsing, not on the initial
> parse.
>
> Can you file this for me? I''ll get it fixed in 0.24.2, which will
be
> out as soon as we start moving two tickets forward for every one
> ticket back. :/