Re: RFC: Environment configured by fact

Philip Walls
Wed, 13 Feb 2008 18:47:07 -0000

Luke,

The patch should be attached to my most recent email (Feb 7, 2008 4:22
PM PST). Let me know if you need me to resend.

On Feb 13, 2008 6:08 AM, Luke Kanies <luke@madstop.com>
wrote:
> On Feb 7, 2008, at 5:59 PM, Philip Walls wrote:
>
> > Luke,
> >
> > I just looked into this a bit further, and it seems that the
> > modifications necessary would actually be entirely client side. The
> > client currently sets the "environment" fact (in
> > networking/client/master.rb) to whatever the configuration value is
> > and passes that to the server during the catalog generation phase.
>
> Huh, you''re right.  I''m not really sure if this was
intentional, but I
> guess I''d accept a patch that preferred a fact to the setting.
>
> >
> > Previously I was assuming that the configuration values were passed
> > independently of facts (eg. options{} in puppet/node.rb), but it
> > appears that this isn''t the case. For example,
options[:environment]
> > (referenced several times in puppet/node.rb to determine the correct
> > environment) appears to always be empty on a 0.24.1 server, even when
> > connecting from a 0.24.1 client. When I modify a 0.24.1 client not to
> > override the environment fact with the configuration option, the
> > environment is selected based on that fact. This seemingly confirms my
> > suspicion.
>
>
> Overall, I''m pretty flexible about how this works, I guess, but
note
> that we''re in a kind of strange in-between state right now.  The
> current network interface doesn''t actually support specifying the
> client environment, so the only way to get it is from the facts.
>
> This will be fixed in 0.25, when the interfaces will be improved
> considerably.
>
> --
> Nature and nature''s laws lay hid in night,
> God said, "Let Newton be," and all was light.
>
> It did not last; the devil howling "Ho!
> Let Einstein be!" restored the status quo.
>
> ---------------------------------------------------------------------
> Luke Kanies | http://reductivelabs.com | http://madstop.com
>
> _______________________________________________
> Puppet-users mailing list
> Puppet-users@madstop.com
> https://mail.madstop.com/mailman/listinfo/puppet-users
>