Andreas Beckmann
2017-Sep-09 13:07 UTC
[Pkg-xen-devel] Bug#874751: blktap-dkms: module FTBFS for Linux 4.12
Package: blktap-dkms Version: 2.0.93-0.10 Severity: serious User: debian-qa at lists.debian.org Usertags: piuparts Hi, blktap-dkms fails to build a module for Linux 4.12: Selecting previously unselected package blktap-dkms. (Reading database ... 34976 files and directories currently installed.) Preparing to unpack .../blktap-dkms_2.0.93-0.10_amd64.deb ... Unpacking blktap-dkms (2.0.93-0.10) ... Setting up blktap-dkms (2.0.93-0.10) ... Loading new blktap-2.0.93 DKMS files... It is likely that 4.6.0-1-amd64 belongs to a chroot's host Building for 4.12.0-1-amd64 Building initial module for 4.12.0-1-amd64 Error! Bad return status for module build on kernel: 4.12.0-1-amd64 (x86_64) Consult /var/lib/dkms/blktap/2.0.93/build/make.log for more information. DKMS make.log for blktap-2.0.93 for kernel 4.12.0-1-amd64 (x86_64) Sat Sep 9 13:04:28 UTC 2017 make: Entering directory '/usr/src/linux-headers-4.12.0-1-amd64' CC [M] /var/lib/dkms/blktap/2.0.93/build/control.o CC [M] /var/lib/dkms/blktap/2.0.93/build/ring.o CC [M] /var/lib/dkms/blktap/2.0.93/build/device.o CC [M] /var/lib/dkms/blktap/2.0.93/build/request.o CC [M] /var/lib/dkms/blktap/2.0.93/build/sysfs.o In file included from /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:66:0, from /var/lib/dkms/blktap/2.0.93/build/blktap.h:33, from /var/lib/dkms/blktap/2.0.93/build/request.c:31: /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:119:24: warning: variably modified 'pending' at file scope sizeof(((struct blktap_sring *)0)->ring[0]))) ^ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:15:59: note: in definition of macro '__RD2' #define __RD2(_x) (((_x) & 0x00000002) ? 0x2 : ((_x) & 0x1)) ^~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:17:66: note: in expansion of macro '__RD4' #define __RD8(_x) (((_x) & 0x000000f0) ? __RD4((_x)>>4)<<4 : __RD4(_x)) ^~~~~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:18:66: note: in expansion of macro '__RD8' #define __RD16(_x) (((_x) & 0x0000ff00) ? __RD8((_x)>>8)<<8 : __RD8(_x)) ^~~~~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:19:66: note: in expansion of macro '__RD16' #define __RD32(_x) (((_x) & 0xffff0000) ? __RD16((_x)>>16)<<16 : __RD16(_x)) ^~~~~~ /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:117:8: note: in expansion of macro '__RD32' ((int)__RD32((BLKTAP_PAGE_SIZE - \ ^~~~~~ /var/lib/dkms/blktap/2.0.93/build/blktap.h:77:41: note: in expansion of macro 'BLKTAP_RING_SIZE' struct blktap_request *pending[BLKTAP_RING_SIZE]; ^~~~~~~~~~~~~~~~ /var/lib/dkms/blktap/2.0.93/build/request.c: In function 'blktap_request_alloc': /var/lib/dkms/blktap/2.0.93/build/request.c:138:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (request) ^~ /var/lib/dkms/blktap/2.0.93/build/request.c:140:6: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' sg_init_table(request->sg_table, ARRAY_SIZE(request->sg_table)); ^~~~~~~~~~~~~ In file included from /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:66:0, from /var/lib/dkms/blktap/2.0.93/build/blktap.h:33, from /var/lib/dkms/blktap/2.0.93/build/control.c:30: /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:119:24: warning: variably modified 'pending' at file scope sizeof(((struct blktap_sring *)0)->ring[0]))) ^ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:15:59: note: in definition of macro '__RD2' #define __RD2(_x) (((_x) & 0x00000002) ? 0x2 : ((_x) & 0x1)) ^~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:17:66: note: in expansion of macro '__RD4' #define __RD8(_x) (((_x) & 0x000000f0) ? __RD4((_x)>>4)<<4 : __RD4(_x)) ^~~~~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:18:66: note: in expansion of macro '__RD8' #define __RD16(_x) (((_x) & 0x0000ff00) ? __RD8((_x)>>8)<<8 : __RD8(_x)) ^~~~~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:19:66: note: in expansion of macro '__RD16' #define __RD32(_x) (((_x) & 0xffff0000) ? __RD16((_x)>>16)<<16 : __RD16(_x)) ^~~~~~ /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:117:8: note: in expansion of macro '__RD32' ((int)__RD32((BLKTAP_PAGE_SIZE - \ ^~~~~~ /var/lib/dkms/blktap/2.0.93/build/blktap.h:77:41: note: in expansion of macro 'BLKTAP_RING_SIZE' struct blktap_request *pending[BLKTAP_RING_SIZE]; ^~~~~~~~~~~~~~~~ /var/lib/dkms/blktap/2.0.93/build/control.c: In function 'blktap_control_ioctl': /var/lib/dkms/blktap/2.0.93/build/control.c:165:7: error: implicit declaration of function 'copy_to_user' [-Werror=implicit-function-declaration] if (copy_to_user(ptr, &info, sizeof(info))) { ^~~~~~~~~~~~ In file included from /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:66:0, from /var/lib/dkms/blktap/2.0.93/build/blktap.h:33, from /var/lib/dkms/blktap/2.0.93/build/sysfs.c:30: /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:119:24: warning: variably modified 'pending' at file scope sizeof(((struct blktap_sring *)0)->ring[0]))) ^ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:15:59: note: in definition of macro '__RD2' #define __RD2(_x) (((_x) & 0x00000002) ? 0x2 : ((_x) & 0x1)) ^~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:17:66: note: in expansion of macro '__RD4' #define __RD8(_x) (((_x) & 0x000000f0) ? __RD4((_x)>>4)<<4 : __RD4(_x)) ^~~~~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:18:66: note: in expansion of macro '__RD8' #define __RD16(_x) (((_x) & 0x0000ff00) ? __RD8((_x)>>8)<<8 : __RD8(_x)) ^~~~~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:19:66: note: in expansion of macro '__RD16' #define __RD32(_x) (((_x) & 0xffff0000) ? __RD16((_x)>>16)<<16 : __RD16(_x)) ^~~~~~ /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:117:8: note: in expansion of macro '__RD32' ((int)__RD32((BLKTAP_PAGE_SIZE - \ ^~~~~~ /var/lib/dkms/blktap/2.0.93/build/blktap.h:77:41: note: in expansion of macro 'BLKTAP_RING_SIZE' struct blktap_request *pending[BLKTAP_RING_SIZE]; ^~~~~~~~~~~~~~~~ In file included from /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:66:0, from /var/lib/dkms/blktap/2.0.93/build/blktap.h:33, from /var/lib/dkms/blktap/2.0.93/build/ring.c:39: /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:119:24: warning: variably modified 'pending' at file scope sizeof(((struct blktap_sring *)0)->ring[0]))) ^ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:15:59: note: in definition of macro '__RD2' #define __RD2(_x) (((_x) & 0x00000002) ? 0x2 : ((_x) & 0x1)) ^~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:17:66: note: in expansion of macro '__RD4' #define __RD8(_x) (((_x) & 0x000000f0) ? __RD4((_x)>>4)<<4 : __RD4(_x)) ^~~~~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:18:66: note: in expansion of macro '__RD8' #define __RD16(_x) (((_x) & 0x0000ff00) ? __RD8((_x)>>8)<<8 : __RD8(_x)) ^~~~~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:19:66: note: in expansion of macro '__RD16' #define __RD32(_x) (((_x) & 0xffff0000) ? __RD16((_x)>>16)<<16 : __RD16(_x)) ^~~~~~ /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:117:8: note: in expansion of macro '__RD32' ((int)__RD32((BLKTAP_PAGE_SIZE - \ ^~~~~~ /var/lib/dkms/blktap/2.0.93/build/blktap.h:77:41: note: in expansion of macro 'BLKTAP_RING_SIZE' struct blktap_request *pending[BLKTAP_RING_SIZE]; ^~~~~~~~~~~~~~~~ In file included from /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:66:0, from /var/lib/dkms/blktap/2.0.93/build/blktap.h:33, from /var/lib/dkms/blktap/2.0.93/build/device.c:32: /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:119:24: warning: variably modified 'pending' at file scope sizeof(((struct blktap_sring *)0)->ring[0]))) ^ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:15:59: note: in definition of macro '__RD2' #define __RD2(_x) (((_x) & 0x00000002) ? 0x2 : ((_x) & 0x1)) ^~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:17:66: note: in expansion of macro '__RD4' #define __RD8(_x) (((_x) & 0x000000f0) ? __RD4((_x)>>4)<<4 : __RD4(_x)) ^~~~~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:18:66: note: in expansion of macro '__RD8' #define __RD16(_x) (((_x) & 0x0000ff00) ? __RD8((_x)>>8)<<8 : __RD8(_x)) ^~~~~ /usr/src/linux-headers-4.12.0-1-common/include/xen/interface/io/ring.h:19:66: note: in expansion of macro '__RD16' #define __RD32(_x) (((_x) & 0xffff0000) ? __RD16((_x)>>16)<<16 : __RD16(_x)) ^~~~~~ /var/lib/dkms/blktap/2.0.93/build/linux-blktap.h:117:8: note: in expansion of macro '__RD32' ((int)__RD32((BLKTAP_PAGE_SIZE - \ ^~~~~~ /var/lib/dkms/blktap/2.0.93/build/blktap.h:77:41: note: in expansion of macro 'BLKTAP_RING_SIZE' struct blktap_request *pending[BLKTAP_RING_SIZE]; ^~~~~~~~~~~~~~~~ /var/lib/dkms/blktap/2.0.93/build/device.c: In function 'blktap_device_make_request': /var/lib/dkms/blktap/2.0.93/build/device.c:214:8: error: 'struct request' has no member named 'cmd_type' if (rq->cmd_type != REQ_TYPE_FS) { ^~ /var/lib/dkms/blktap/2.0.93/build/device.c:214:22: error: 'REQ_TYPE_FS' undeclared (first use in this function) if (rq->cmd_type != REQ_TYPE_FS) { ^~~~~~~~~~~ /var/lib/dkms/blktap/2.0.93/build/device.c:214:22: note: each undeclared identifier is reported only once for each function it appears in /var/lib/dkms/blktap/2.0.93/build/device.c: In function 'blktap_device_configure': /var/lib/dkms/blktap/2.0.93/build/device.c:374:9: error: 'struct queue_limits' has no member named 'discard_zeroes_data' limits->discard_zeroes_data = trz; ^~ In file included from /usr/src/linux-headers-4.12.0-1-common/include/linux/genhd.h:64:0, from /usr/src/linux-headers-4.12.0-1-common/include/linux/blkdev.h:10, from /var/lib/dkms/blktap/2.0.93/build/device.c:24: /var/lib/dkms/blktap/2.0.93/build/device.c: In function 'blktap_device_create': /var/lib/dkms/blktap/2.0.93/build/device.c:582:4: warning: format '%x' expects argument of type 'unsigned int', but argument 9 has type 'long unsigned int' [-Wformat=] "sector-size: %u/%u+%u capacity: %llu" ^ /usr/src/linux-headers-4.12.0-1-common/include/linux/device.h:1319:51: note: in definition of macro 'dev_info' #define dev_info(dev, fmt, arg...) _dev_info(dev, fmt, ##arg) ^~~ /usr/src/linux-headers-4.12.0-1-common/scripts/Makefile.build:307: recipe for target '/var/lib/dkms/blktap/2.0.93/build/device.o' failed make[3]: *** [/var/lib/dkms/blktap/2.0.93/build/device.o] Error 1 make[3]: *** Waiting for unfinished jobs.... cc1: some warnings being treated as errors /usr/src/linux-headers-4.12.0-1-common/scripts/Makefile.build:307: recipe for target '/var/lib/dkms/blktap/2.0.93/build/control.o' failed make[3]: *** [/var/lib/dkms/blktap/2.0.93/build/control.o] Error 1 /usr/src/linux-headers-4.12.0-1-common/Makefile:1532: recipe for target '_module_/var/lib/dkms/blktap/2.0.93/build' failed make[2]: *** [_module_/var/lib/dkms/blktap/2.0.93/build] Error 2 Makefile:152: recipe for target 'sub-make' failed make[1]: *** [sub-make] Error 2 Makefile:8: recipe for target 'all' failed make: *** [all] Error 2 make: Leaving directory '/usr/src/linux-headers-4.12.0-1-amd64' Cheers Andreas
Stephen Gelman
2018-Aug-19 05:19 UTC
[Pkg-xen-devel] Bug#874751: blktap-dkms: module FTBFS for Linux 4.12
I took a stab at creating a patch to get this to build on a 4.17 kernel. It builds, but when I tried to actually use it, it caused a kernel panic. (FYI I used the instructions at https://wiki.xenproject.org/wiki/Mounting_a_.vhd_disk_image_using_blktap/tapdisk to attempt to mount the disk). I’m a little out of my depth debugging this one so I wanted to submit the patch I have in case anyone else can benefit from it. Having said that I’m not sure this package should even stay in Debian. Popcon reports 55 installs and I can’t even find the upstream sources. The closest I can find is https://github.com/xapi-project/blktap/tree/master/drivers but that doesn’t actually have a version 2.0.93… Also, the last maintainer upload was in 2013 and the package has had 10 consecutive NMUs. Some brief searching indicates that this may now be part of Xen itself anyway… -------------- next part -------------- A non-text attachment was scrubbed... Name: blktap-compile-on-4.17.patch Type: application/octet-stream Size: 2648 bytes Desc: not available URL: <http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20180819/9623b2ed/attachment-0001.obj>
Thomas Goirand
2018-Dec-31 04:53 UTC
[Pkg-xen-devel] Bug#874751: Processed: severity of 874751 is grave
I am probably still registered as maintainer of this package, however it's been years I am not involves with, neither interested by it. If someone uploads it once more, please remove me from uploaders. Cheers, Thomas Goirand (zigo)
Hans van Kranenburg
2018-Dec-31 14:49 UTC
[Pkg-xen-devel] Bug#874751: Bug#874751: Processed: severity of 874751 is grave
Hi, So, this is about: https://packages.debian.org/source/sid/blktap-dkms Related (also with a long living ftbfs bug): https://packages.debian.org/source/sid/blktap I can already tell that while the Debian Xen team is listed as maintainer, the packages are not anywhere on the radar of the current team. It seems the packages were added as part of packaging "The Xen Cloud Platform (XCP)". According to... https://www.xenproject.org/developers/teams/xapi.html ... "Before June 2013, XenServer was not fully open sourced and a subset of XenServer called XCP was made available [...]" ...and... https://wiki.xen.org/wiki/Blktap2 "Xen blktap2 is a successor to the old blktap1 disk backend driver. [...] Xen blktap2 support is included in the Xen version 4.0 released in Apr 2010." ...the XCP project was stopped in 2013 and this v1 of blktap has been obsoleted upstream. So, since this dkms was already not usable since Wheezy... What about solving this by getting both of them removed from Debian? The blktap source package also builds a library to access vhd files... https://packages.debian.org/sid/libvhd0 ...but there seems to be an alternative for that, if anyone was using it... https://packages.debian.org/sid/libvhdi1 Hans
Ben Hutchings
2018-Dec-31 15:03 UTC
[Pkg-xen-devel] Bug#874751: Bug#874751: Processed: severity of 874751 is grave
On Mon, 2018-12-31 at 15:49 +0100, Hans van Kranenburg wrote: [...]> https://wiki.xen.org/wiki/Blktap2 > "Xen blktap2 is a successor to the old blktap1 disk backend driver. > [...] Xen blktap2 support is included in the Xen version 4.0 released in > Apr 2010." > > ...the XCP project was stopped in 2013 and this v1 of blktap has been > obsoleted upstream. > > So, since this dkms was already not usable since Wheezy... What about > solving this by getting both of them removed from Debian?[...] OK, I've opened RM bugs for these two. Ben. -- Ben Hutchings Power corrupts. Absolute power is kind of neat. - John Lehman -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: This is a digitally signed message part URL: <http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20181231/c3081525/attachment.sig>
Debian Bug Tracking System
2019-Jan-02 06:21 UTC
[Pkg-xen-devel] Bug#874751: marked as done (blktap-dkms: module FTBFS for Linux 4.12)
Your message dated Wed, 02 Jan 2019 06:18:36 +0000 with message-id <E1geZrQ-000InZ-Tk at fasolo.debian.org> and subject line Bug#917908: Removed package(s) from unstable has caused the Debian Bug report #874751, regarding blktap-dkms: module FTBFS for Linux 4.12 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner at bugs.debian.org immediately.) -- 874751: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874751 Debian Bug Tracking System Contact owner at bugs.debian.org with problems -------------- next part -------------- An embedded message was scrubbed... From: Andreas Beckmann <anbe at debian.org> Subject: blktap-dkms: module FTBFS for Linux 4.12 Date: Sat, 09 Sep 2017 15:07:23 +0200 Size: 15131 URL: <http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20190102/f1502caa/attachment-0002.mht> -------------- next part -------------- An embedded message was scrubbed... From: Debian FTP Masters <ftpmaster at ftp-master.debian.org> Subject: Bug#917908: Removed package(s) from unstable Date: Wed, 02 Jan 2019 06:18:36 +0000 Size: 2877 URL: <http://alioth-lists.debian.net/pipermail/pkg-xen-devel/attachments/20190102/f1502caa/attachment-0003.mht>