[opus] [PATCH] Move demixing matrix defines

Drew Allen
Thu, 08 Mar 2018 23:43:52 -0000

Hello Jean-Marc et all,

I've attached an updated patch which I feel addresses all 3 cases.

PTAL, Thanks!

Cheers,
Drew

On Wed, Mar 7, 2018 at 8:39 PM Jean-Marc Valin <jmvalin at jmvalin.ca>
wrote:

> Make sure the modified libraries work in all of these three cases:
> 1) libopus 1.2.1
> 2) libopus master (or 1.3-beta) with --enable-ambisonics
> 3) libopus master (or 1.3-beta) with --disable-ambisonics
>
> I suspect with the current set of patches you might have problems with
> case 3) since you will find the symbols in the header file, but the
> functionality won't be there.
>
> Cheers,
>
>         Jean-Marc
>
> On 03/07/2018 02:40 PM, Drew Allen wrote:
> > Move demixing matrix defines to opus_define to better determine
> > availability of Projection API.
> >
> > Allows libopusenc, opusfile and opus-tools to much more easily
determine
> > availability of Projection API.
> >
> > Cheers,
> > Drew
> >
> >
> > _______________________________________________
> > opus mailing list
> > opus at xiph.org
> > http://lists.xiph.org/mailman/listinfo/opus
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/opus/attachments/20180308/1bd79961/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libopus-Allow-users.patch
Type: text/x-patch
Size: 5561 bytes
Desc: not available
URL:
<http://lists.xiph.org/pipermail/opus/attachments/20180308/1bd79961/attachment.bin>