[opus] ARM NEON optimization -- celt_fir()

Linfeng Zhang
2016-06-17T22:26:05Z

Hi Jonathan,

Thanks for pointing me to the related submissions!

I noticed the xcorr_kernel_neon() assembly in current code base, but don't
know why it's not activated for celt_fir() etc. So I decided to inline it
inside celt_fir() to save the sum[] buffer initializing/saving/loading, and
handle variable filter order "ord" differently.

Thanks,
Linfeng

On Fri, Jun 17, 2016 at 2:37 PM, Jonathan Lennox <jonathan at vidyo.com>
wrote:

> Hi, Linfeng —
>
> Please note the aarch64 optimization patches I submitted in November and
> December (which Tim still hasn’t gotten around to reviewing).  As they used
> Neon intrinsics, several of these actually applied to both armv7 and
> aarch64 Neon.
>
> In particular, note
> http://lists.xiph.org/pipermail/opus/2015-December/003339.html , which
> added a Neon-optimized version of xcorr_kernel.  xcorr_kernel is used in
> celt_fir, celt_iir, and celt_pitch_xcorr.
>
> > On Jun 17, 2016, at 5:09 PM, Linfeng Zhang <linfengz at
google.com> wrote:
> >
> > Hi all,
> >
> > This is Linfeng Zhang from Google. I'll work on ARM NEON
optimization in
> the
> > next few months.
> >
> > I'm submitting 2 patches in the following couple of emails, which
have
> the new
> > created celt_fir_neon().
> >
> > I revised celt_fir_c() to not pass in argument "mem" in
Patch 1. If
> there are
> > concerns to this change, please let me know.
> >
> > Many thanks to your comments.
> >
> > Linfeng Zhang
> >
> > _______________________________________________
> > opus mailing list
> > opus at xiph.org
> > http://lists.xiph.org/mailman/listinfo/opus
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/opus/attachments/20160617/2dc691ef/attachment.html>