Call for testing: OpenSSH 10.1p1

Sevan Janiyan
2025-09-30T23:48:51Z

On 30/09/2025 14:45, Damien Miller wrote:
> Live testing on suitable non-production systems is also appreciated.

Built fine & ran tests without issue out of the box on macOS 10.15
Catalina, linking against OpenSSL 3.4.x.

clock_gettime and its various clock_id definitions didn't show up in
darwin until macOS 10.12 Sierra (darwin 16).
The autoconf infra already checks for clock_gettime() so I added a guard
in misc-agent.c which allowed OpenSSH to build on
There are two calls to clock_gettime() in
regress/unittests/test_helper/test_helper.c which I just commented out
to move forward.

The comment in the header of regress/keygen-comment.sh seems corrupt and
it trips up ancient bash (2.05b) on ancient OS X (10.4) resulting in the
error "regress/keygen-comment.sh: cannot execute binary file" when
running the test suite. I cleared that up.

With these changes it was possible to build and run the test suite on
Mac OS X 10.4.11 PowerPC (on G4 & G5), linking against OpenSSL 3.5.x

Had to configure with --disable-security-key as the build infra uses
"-shared" for building libraries and ancient OS X doesn't
recognise
that. Will provide a patch for that if/when I get to look at it on a
rainy day.


Sincerely,


Sevan
-------------- next part --------------
--- openssh.orig/misc-agent.c	2025-09-30 01:19:15.000000000 +0100
+++ openssh/misc-agent.c	2025-09-30 20:24:27.000000000 +0100
@@ -279,11 +279,13 @@
 	char *prefix = NULL, *dirpath = NULL, *path = NULL;
 	struct timespec now, sub, *mtimp = NULL;

+#if defined(HAVE_CLOCK_GETTIME) && defined(CLOCK_REALTIME)
 	/* Only consider sockets last modified > 1 hour ago */
 	if (clock_gettime(CLOCK_REALTIME, &now) != 0) {
 		error_f("clock_gettime: %s", strerror(errno));
 		return;
 	}
+#endif /* HAVE_CLOCK_GETTIME && REALTIME */
 	sub.tv_sec = 60 * 60;
 	sub.tv_nsec = 0;
 	timespecsub(&now, &sub, &now);
--- openssh.orig/regress/keygen-comment.sh	2025-09-30 01:19:15.000000000 +0100
+++ openssh/regress/keygen-comment.sh	2025-09-30 21:16:41.000000000 +0100
@@ -1,4 +1,5 @@
-#??? Placed in the Public Domain.
+# 	$OpenBSD$
+# 	Placed in the Public Domain.

 tid="Comment extraction from private key"