ssh-copy-id bugfix

Nico Kadel-Garcia
Wed, 25 Nov 2015 12:24:36 -0000

On Wed, Nov 25, 2015 at 6:07 AM, Ruediger Meier <sweet_f_a at gmx.de>
wrote:
> Hi,
>
> On Tuesday 24 November 2015, Radek Podgorny wrote:
>> hello everyone!
>>
>> i'd like to sincerely ask you to include a fix for ssh-copy-id bug
>> i'll be linking below. it's a trivial fix which resolves
>> https://bugzilla.mindrot.org/show_bug.cgi?id=2206 and eases life of
>> many. it's been field-tested by redhat devs and users so i see no
>> problem in incorporating it.
>>
>> http://pkgs.fedoraproject.org/cgit/openssh.git/tree/openssh-6.8p1-fix
>>-ss h-copy-id-on-non-sh-shell.patch

> Personally I think it's hard enough to write POSIX compatible shell
> scripts and I wouldn't start to add such hacks for fish and tcsh.
> Next week somebody may complain that his "shell" does not
> support "exec ...".

Making things work for more people, when it doesn't introduce a
security risk or break other tools, seems very reasonable. And there
are people out there who who do use both fish and tcsh.

What seems to be missing in the patch is a comment line, above the
stanza, explaining why the code uses "exec". It's great to be
clever
and solve a problem, but it boosts your pay and makes people who
follow in your role hate you a lot less if they can understand why you
chose a particular solution.