Call for testing: OpenSSH 6.8

Damien Miller
Tue, 24 Feb 2015 19:20:04 -0000

On Tue, 24 Feb 2015, Tom G. Christensen wrote:

> I've switched to HEAD in the git repo and it now builds on Solaris
> 2.6, 7, 8 and 9 but the testsuite still cannot be built due to the
> missing <err.h>.
>
> I noticed one of the changes was about HOST_NAME_MAX but I don't
> think that change addresses the real issue on at least these old
> Solaris systems. It looks to me like the fall back in defines.h
> was not activated because Solaris has MAXHOSTNAMELEN in <netdb.h>
> which has not been included when defines.h tries to find a fall back
> HOST_NAME_MAX.
>
> Looking at sshd.c with gcc -dD -E confirms it as defines.h now set
> HOST_NAME_MAX to 255 and later <netdb.h> is included which then
> defines MAXHOSTNAMELEN to 256.
>
> I don't know if it would be reasonable to include <netdb.h>
> from includes.h but that would make HOST_NAME_MAX fall back to
> MAXHOSTNAMELEN on at least Solaris < 10.

I guess we could do this:

diff --git includes.h includes.h
index c3034e3..ec74998 100644
--- includes.h
+++ includes.h
@@ -171,6 +171,8 @@
 #include <openssl/opensslv.h> /* For OPENSSL_VERSION_NUMBER */
 #endif

+#include <netdb.h> /* For MAXHOSTNAMELEN */
+
 #include "defines.h"

 #include "platform.h"