Call for testing: OpenSSH 6.8

Damien Miller
Fri, 06 Mar 2015 17:34:20 -0000

On Fri, 6 Mar 2015, Martin Hecht wrote:

> on Ubuntu 14.04 with openssh-SNAP-20150306.tar.gz with gcc, libz-dev,
> and libssl-dev
>
> configure; make; make tests
>
> fails at:
>
> test_hostkeys:
> regress/unittests/hostkeys/test_iterate.c:124 test #1
"hostkeys_iterate
> all with key parse" - entry 5/61, file line 5
> ASSERT_PTR_EQ(l->key, NULL) failed:
>       l->key = 0x2b14c2d7af80
>         NULL = (nil)

Already fixed in HEAD:

diff --git sshkey.c sshkey.c
index 2c67809..680c707 100644
--- sshkey.c
+++ sshkey.c
@@ -2464,6 +2464,7 @@ sshkey_certify(struct sshkey *k, struct sshkey *ca)
 		break;
 	default:
 		ret = SSH_ERR_INVALID_ARGUMENT;
+		goto out;
 	}

 	/* -v01 certs have a serial number next */