Call for testing: OpenSSH 6.8

Damien Miller
Tue, 24 Feb 2015 02:39:49 -0000

On Tue, 24 Feb 2015, Darren Tucker wrote:

> Next thing I ran into: fake-rfc2553 doesn't have AI_NUMERICSERV.
>
> By my read it never attempts to return a non-numeric service so I think
> all that's need is this.  OK?

well, getnameinfo always returns a numeric service name but AI_NUMERICSERV
is for getaddrinfo.

fortunately, we deal with this case too; getaddrinfo tries to parse the
port numerically before getservbyname

ok djm

> diff --git a/openbsd-compat/fake-rfc2553.h b/openbsd-compat/fake-rfc2553.h
> index 3e9090f..6426f7b 100644
> --- a/openbsd-compat/fake-rfc2553.h
> +++ b/openbsd-compat/fake-rfc2553.h
> @@ -109,6 +109,9 @@ struct sockaddr_in6 {
>  #ifndef AI_NUMERICHOST
>  # define AI_NUMERICHOST		(1<<2)
>  #endif
> +#ifndef AI_NUMERICSERV
> +# define AI_NUMERICSERV		(1<<3)
> +#endif
>
>  #ifndef NI_MAXSERV
>  # define NI_MAXSERV 32
>
> --
> Darren Tucker (dtucker at zip.com.au)
> GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
>     Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.
>