Call for testing: OpenSSH 6.8

Damien Miller
Mon, 23 Feb 2015 18:00:43 -0000

On Mon, 23 Feb 2015, mikep at noc.utoronto.ca wrote:

> openssh-SNAP-20150224, Solaris 10, GCC

Thanks for testing.

> Configure command line:
>
> ./configure CC=gcc --prefix=/opt/local --sysconfdir=/etc/ssh
> --with-prngd-socket=/var/run/egd-pool --with-zlib=/opt/local --with-rpath
>
> Have to manually edit 'config.h':
>
> diff config.h.orig config.h
> 783c783
> < #define HAVE_MKDTEMP 1
> ---
> > /* #undef HAVE_MKDTEMP */
>
> as Solaris does not have 'mkdtemp'.

That's strange - it's finding it somewhere. Could I ask you to rummage
through config.log to see what it is detecting?

> Compile fails at:
>
> gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare
> -Wformat-security -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv
> -fno-builtin-memset  -I. -I. -I/opt/local/include
-DSSHDIR=\"/etc/ssh\"
> -D_PATH_SSH_PROGRAM=\"/opt/local/bin/ssh\"
> -D_PATH_SSH_ASKPASS_DEFAULT=\"/opt/local/libexec/ssh-askpass\"
> -D_PATH_SFTP_SERVER=\"/opt/local/libexec/sftp-server\"
> -D_PATH_SSH_KEY_SIGN=\"/opt/local/libexec/ssh-keysign\"
>
-D_PATH_SSH_PKCS11_HELPER=\"/opt/local/libexec/ssh-pkcs11-helper\"
> -D_PATH_SSH_PIDDIR=\"/var/run\"
-D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\"
> -DHAVE_CONFIG_H -c canohost.c -o canohost.o
> In file included from packet.h:45,
>                  from canohost.c:33:
> dispatch.h:46: warning: type defaults to `int' in declaration of
> `sig_atomic_t'
> dispatch.h:46: error: syntax error before '*' token
> dispatch.h:47: warning: type defaults to `int' in declaration of
> `sig_atomic_t'
> dispatch.h:47: error: syntax error before '*' token
> make: *** [canohost.o] Error 1

Does this help?

diff --git a/dispatch.h b/dispatch.h
index cd51dbc..2bcdc91 100644
--- a/dispatch.h
+++ b/dispatch.h
@@ -27,6 +27,8 @@
 #ifndef DISPATCH_H
 #define DISPATCH_H

+#include <signal.h> /* for sig_atomic_t */
+
 #define DISPATCH_MAX	255

 enum {