Call for testing: OpenSSH 6.7

Corinna Vinschen
2014-09-02T11:49:49Z

On Aug 18 11:23, Damien Miller wrote:
> Hi,
>
> OpenSSH 6.7 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is a big release
> containing a number of features, a lot of internal refactoring and some
> potentially-incompatible changes.

Btw., I'm getting two new warnings during build:

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare
-Wformat-security -Wsizeof-pointer-memaccess -Wno-pointer-sign
-Wno-unused-result -fno-strict-aliasing -D_FORTIFY_SOURCE=2 -ftrapv
-fno-builtin-memset -fstack-protector-all -Wno-attributes  -I. -I../src
-I/usr/include/editline    -DSSHDIR=\"/etc\"
-D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\"
-D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/sbin/ssh-askpass\"
-D_PATH_SFTP_SERVER=\"/usr/sbin/sftp-server\"
-D_PATH_SSH_KEY_SIGN=\"/usr/sbin/ssh-keysign\"
-D_PATH_SSH_PKCS11_HELPER=\"/usr/sbin/ssh-pkcs11-helper\"
-D_PATH_SSH_PIDDIR=\"/var/run\"
-D_PATH_PRIVSEP_CHROOT_DIR=\"/var/empty\" -DHAVE_CONFIG_H -c
../src/sshbuf.c -o sshbuf.o
../src/sshbuf.c:34:0: warning: "__predict_true" redefined [enabled by
default]
 #define __predict_true(exp)     __builtin_expect(((exp) != 0), 1)
 ^
In file included from /usr/include/features.h:14:0,
                 from /usr/include/sys/socket.h:15,
                 from ../src/includes.h:26,
                 from ../src/sshbuf.c:19:
/usr/lib/gcc/x86_64-pc-cygwin/4.8.3/include-fixed/sys/cdefs.h:445:0: note: this
is the location of the previous definition
 #define __predict_true(exp)     __builtin_expect((exp), 1)
 ^
../src/sshbuf.c:35:0: warning: "__predict_false" redefined [enabled by
default]
 #define __predict_false(exp)    __builtin_expect(((exp) != 0), 0)
 ^
In file included from /usr/include/features.h:14:0,
                 from /usr/include/sys/socket.h:15,
                 from ../src/includes.h:26,
                 from ../src/sshbuf.c:19:
/usr/lib/gcc/x86_64-pc-cygwin/4.8.3/include-fixed/sys/cdefs.h:446:0: note: this
is the location of the previous definition
 #define __predict_false(exp)    __builtin_expect((exp), 0)
 ^

Shouldn't these be avoided by only defining them if they are not already
defined?


Corinna

--
Corinna Vinschen
Cygwin Maintainer
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL:
<http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20140902/ac71b691/attachment.bin>