Probs with Solaris 2.6

Damien Miller
2000-06-22T10:40:26Z

On Thu, 22 Jun 2000, Chiaki Ishikawa wrote:

> X-PMC-CI-e-mail-id: 13125
>
> >This dropped my session of course, big deal I thought, but the
> >host dropped to single user mode and stopped accepting
> >connections.  This leads me to suspect that events on a
> >redirected session inside an ssh session, can effect the health
> >of the box the client is run on..
>
> This sounds to me a
>
> 	kill (-1, whatever)
>
> is executed by mistake on the host.
> (Yeah, this sounds like a bug.)

Can you try this patch and keep an eye out for errors of the form
"session_close_by_channel: Unsafe s->pid = XXX" in your logs?

Regards,
Damien Miller

diff -u -r1.18 session.c
--- session.c	2000/06/18 04:50:44	1.18
+++ session.c	2000/06/22 10:33:08
@@ -1608,7 +1608,9 @@
 		session_close(s);
 	} else {
 		/* notify child, delay session cleanup */
-		if (kill(s->pid, (s->ttyfd == -1) ? SIGTERM : SIGHUP) < 0)
+		if (s->pid <= 1)
+			error("session_close_by_channel: Unsafe s->pid = %d",
s->pid);
+		else if (kill(s->pid, (s->ttyfd == -1) ? SIGTERM : SIGHUP) < 0)
 			error("session_close_by_channel: kill %d: %s",
 			    s->pid, strerror(errno));
 	}


--
| "Bombay is 250ms from New York in the new world order" - Alan Cox
| Damien Miller - http://www.mindrot.org/
| Email: djm at mindrot.org (home) -or- djm at ibs.com.au (work)