[Ocfs2-devel] [PATCH v3 1/9] string: introduce memweight

Akinobu Mita
2012-06-21T09:07:16Z

2012/6/21 Tony Luck <tony.luck at gmail.com>:
> On Fri, Jun 8, 2012 at 5:50 PM, Akinobu Mita <akinobu.mita at
gmail.com> wrote:
>> ?lib/string.c ? ? ? ? ? | ? 36 ++++++++++++++++++++++++++++++++++++
>
> Is lib/string.c the right place for this? ?I get a build error on the
> ia64 sim_defconfig:
>
> ?LD ? ? ?arch/ia64/hp/sim/boot/bootloader
>
> It fails because it pulls in lib/lib.a(string.o) to get some
> innocuous function like strcpy() ... but it also gets
> given memweight() which relies on __bitmap_weight()
> which it doesn't have, because it doesn't include lib/built-in.o
> (which is where bitmap.o, the definer of __bitmap_weight(), has
> been linked).
>
> Moving memweight() to lib/bitmap.c fixes the problem. But it
> isn't really clear that it belongs there either. ?Perhaps it should
> be its own file lib/memweight.c that gets included in lib/lib.a?

I'll fix it by making lib/memweight.c as you suggested.
Thanks for your report and suggestion.