Stan, I'm very pleased to see you back to work with us on enhancing nut in that many areas ;-) 2008/4/30 Stanislav Brabec <sbrabec at suse.cz>:> Stanislav Brabec wrote: > > > Please note that 2.2.2-pre3 installs hald addons by default to / on > > openSUSE 11.0 beta 2 x86_64. Not a big problem. > > Here is a patch, which fixes openSUSE 11.0 beta 2 x86_64: > > --- m4/nut_check_libhal.m4 > +++ m4/nut_check_libhal.m4 > @@ -63,7 +63,7 @@ > dnl As per HAL spec, ?5 Callouts and ?2 Device Information Files > dnl - addon install path: $libdir/hal > AC_MSG_CHECKING(for libhal Callouts path) > - if (test -d "/usr/lib/hal") > + if (test -d "${libdir}/hal") > then > # For Debian > HAL_CALLOUTS_PATH="${libdir}/hal"applied in Testing and trunk. thanks.> I found another problem - nut-2.2.2-pre3 is not parallel build ready and > parallel build fails in ~80% of cases. It seems that dependencies are > not complete. > > Build on one processor works. > ...I've seen another mail from a SuSE guy, and fwded by Arjen, about libtool and possibly dependencies. I gotta check it. if you have a patch underhand, just forward it. I can wait just a bit more of the final 2.2.2, but not that much since it's already more than late. have a nice week end (we're off in France...) Arnaud -- Linux / Unix Expert R&D - MGE Office Protection Systems - http://www.mgeops.com Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://people.debian.org/~aquette/ Free Software Developer - http://arnaud.quette.free.fr/
before going on week end, just a small one line patch to test for the // build 2008/4/30 Arnaud Quette <aquette.dev at gmail.com>:> ... > > I found another problem - nut-2.2.2-pre3 is not parallel build ready and > > parallel build fails in ~80% of cases. It seems that dependencies are > > not complete. > > > > Build on one processor works. > > ... > > I've seen another mail from a SuSE guy, and fwded by Arjen, about > libtool and possibly dependencies. I gotta check it. > if you have a patch underhand, just forward it. I can wait just a bit > more of the final 2.2.2, but not that much since it's already more > than late.--- clients/Makefile.am (r?vision 1455) +++ clients/Makefile.am (copie de travail) @@ -1,7 +1,7 @@ # Network UPS Tools: clients # by default, link programs in this directory with libcommon.a -LDADD = ../common/libcommon.a -lupsclient $(NETLIBS) +LDADD = ../common/libcommon.a libupsclient.la $(NETLIBS) if WITH_SSL LDADD += $(LIBSSL_LDFLAGS) endif I've tested it with "make -j2", and 2 config set (--disable-shared for full static, and --enable-static for linking clients on the shared lib while still shipping the static lib) and everything seems fine. Can you confirm on your side? thanks, Arnaud -- Linux / Unix Expert R&D - MGE Office Protection Systems - http://www.mgeops.com Network UPS Tools (NUT) Project Leader - http://www.networkupstools.org/ Debian Developer - http://people.debian.org/~aquette/ Free Software Developer - http://arnaud.quette.free.fr/
Arnaud Quette wrote:> I've seen another mail from a SuSE guy, and fwded by Arjen, about > libtool and possibly dependencies. I gotta check it.Probably Andreas Schwab. His patch (see the attachment) applies on 2.2.2, but breaks the build. Without his patch, it fails on IA64 and S390. I will look deeper into it: gcc -DHAVE_CONFIG_H -I. -I../include -I../include -O2 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -Wall -Wsign-compare -MT parseconf.lo -MD -MP -MF .deps/parseconf.Tpo -c parseconf.c -fPIC -DPIC -o .libs/parseconf.o mv -f .deps/state.Tpo .deps/state.Po mv -f .deps/parseconf.Tpo .deps/parseconf.Po mv -f .deps/common.Tpo .deps/common.Po rm -f libcommon.a /usr/bin/ar cru libcommon.a common.o ranlib libcommon.a mv -f .deps/parseconf.Tpo .deps/parseconf.Plo mv: cannot stat `.deps/parseconf.Tpo': No such file or directory make[1]: *** [parseconf.lo] Error 1 make[1]: Leaving directory `/usr/src/packages/BUILD/nut-2.2.2-pre3/common' make: *** [all-recursive] Error 1 I am attaching one another cosmetic patch. It prevents warning mentioned in the patch preamble, which is considered as error by SuSE QA tools. Adding an explicit cast lets to know to the compiler, that cast from integer for void * is really intended here. Arnaud Quette wrote:> I've tested it with "make -j2", and 2 config set (--disable-shared for > full static, and --enable-static for linking clients on the shared lib > while still shipping the static lib) and everything seems fine. > Can you confirm on your side?Yes, it seems to fix parallel build. Tried ~10 times, no failure. Regarding my hald-addon path patch - it is an intermediate solution, which will probably break in SuSE: https://bugzilla.novell.com/show_bug.cgi?id=304316 But I guess that upstream will take care of correct setting of hald-addon directory (see bugs in my previous mail). -- Best Regards / S pozdravem, Stanislav Brabec software developer --------------------------------------------------------------------- SUSE LINUX, s. r. o. e-mail: sbrabec at suse.cz Lihovarsk? 1060/12 tel: +420 284 028 966, +49 911 740538747 190 00 Praha 9 fax: +420 284 028 951 Czech Republic http://www.suse.cz/ -------------- next part -------------- A non-text attachment was scrubbed... Name: nut-libtool.diff Type: text/x-patch Size: 1587 bytes Desc: not available Url : http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20080502/3765bb76/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: nut-intptr.patch Type: text/x-patch Size: 1004 bytes Desc: not available Url : http://lists.alioth.debian.org/pipermail/nut-upsdev/attachments/20080502/3765bb76/attachment-0001.bin