[Nouveau] [PATCH 1/3] drm: Add separate state structure for legacy, non-KMS drivers

Emil Velikov
Tue, 25 Feb 2020 17:37:23 -0000

Hi Thomas,

On Tuesday, 25 February 2020, Thomas Zimmermann <tzimmermann at suse.de>
wrote:

> Non-KMS drivers store state in struct drm_driver. This bloats the
> structure for KMS drivers and prevents it from being declared with
> 'static const' qualifiers. Moving the non-KMS state into a separate
> data structure resolves this.
>
>
Have you considered subclassing the const drm_driver for legacy drivers.
This way the legacy (pointer) data does not need to be exposed to
non-legacy drivers.

Not to mention that const data (drm_driver), which has (const) pointer to
mutable data (legacy bits) is a trap IMHO

Emil
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20200225/d84d213c/attachment.htm>