[Nouveau] [PATCH 1/7] Revert "ACPI / OSI: Add OEM _OSI string to enable dGPU direct output"

Daniel Vetter
Thu, 15 Aug 2019 14:11:00 -0000

On Thu, Aug 15, 2019 at 12:47 AM Dave Airlie <airlied at gmail.com>
wrote:
>
> On Thu, 15 Aug 2019 at 07:31, Karol Herbst <kherbst at redhat.com>
wrote:
> >
> > This reverts commit 28586a51eea666d5531bcaef2f68e4abbd87242c.
> >
> > The original commit message didn't even make sense. AMD _does_
support it and
> > it works with Nouveau as well.
> >
> > Also what was the issue being solved here? No references to any bugs
and not
> > even explaining any issue at all isn't the way we do things.
> >
> > And even if it means a muxed design, then the fix is to make it work
inside the
> > driver, not adding some hacky workaround through ACPI tricks.
> >
> > And what out of tree drivers do or do not support we don't care
one bit anyway.
> >
>
> I think the reverts should be merged via Rafael's tree as the original
> patches went in via there, and we should get them in asap.

+1

> Acked-by: Dave Airlie <airlied at redhat.com>

Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Also fully agreeing with Karol's reply further down, if this doesn't
work we need to improve the drivers, not pile stuff on top in some
ACPI hacks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch