[Masterview-devel] Code review request

Jeff Barczewski
Wed, 11 Oct 2006 17:42:33 -0000

On 10/8/06, Deb Lewis <djlewis at acm.org> wrote:
> Jeff - please code review the changes I''m proposing to make to
analyzer.rb
> before I submit that; I ended up doing more than just cosmetic
name-changing
> and I''m not sure how good how test coverage is in this area, so
I''d like you
> to check before I commit.
>
> Objective: getting rid of the MasterView::NamespacePrefix constant(s), I
> don''t think a module-level constant is the right way to expose
that, esp.
> since we now have 2 flavors of namespace defaults (mv: and mvx:).
>
>
rubyforge.org/var/svn/masterview/branches/djl-analyzer-changes-preview/analy
> zer.rb - I put out a copy from the trunk and then stored changes so you
> should be able to diff the two versions there in the branch.

I reviewed the code Deb and I think it looks good. Go ahead and
commit. Once you commit it to the trunk we''ll just have to test this
code to be sure.

Thanks,

Jeff