Logcheck devel - May 2004 - cleanup of tmp dirs in 1.2.20

On Sat, May 15, 2004 at 03:52:47AM -0600, CVS User maks-guest
wrote:
> Update of /cvsroot/logcheck/logcheck/src
> In directory haydn:/tmp/cvs-serv28425/src
> 
> Modified Files:
> 	logcheck 
> Log Message:
> 
> my stupid patch for allowing mktemp in /tmp had an unexpected behaviour:
> * it does first a mktemp in /var/temp that we happily ignore.
> so we have now for 1.2.20 many /var/tmp/logcheck.XXXXX dirs.
> sorry, but bad review ;)
Eek, this is fairly critical as it has the potential to create a LOT of
directories.  I think we should probably release before sargeing again
unfortunately :\  I should have caught this one too.

Maybe just a fix release with only this change to be tested tomorrow?

Also, any ideas about version numbering for fix releases?  It seems
somehow inappropriate to mark this change .21, but if that is what
is best, I will use it.
> 
> 
> --- /cvsroot/logcheck/logcheck/src/logcheck	2004/05/15 08:41:08	1.25
> +++ /cvsroot/logcheck/logcheck/src/logcheck	2004/05/15 09:52:47	1.26
> @@ -22,7 +22,7 @@
>  # along with Logcheck; if not, write to the Free Software
>  # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 
USA
>  
> -# $Id: logcheck,v 1.25 2004/05/15 08:41:08 ttroxell Exp $
> +# $Id: logcheck,v 1.26 2004/05/15 09:52:47 maks-guest Exp $
>  
>  
>  # Set the umask
> @@ -521,7 +521,7 @@
>  
>  # Create the secure temporary directory or exit
>  TMPDIR=$(mktemp -d -p /var/tmp logcheck.XXXXXXXX) \
> -TMPDIR=$(mktemp -d -p /tmp logcheck.XXXXXXXX) \
> +    || TMPDIR=$(mktemp -d -p /tmp logcheck.XXXXXXXX) \
>      || error "Could not create temporary directory"
>  
>  # Now clean the rulefiles in the directories
-- 
[   Todd J. Troxell                                         ,''`.
      Student, Debian GNU/Linux Developer, SysAdmin, Geek  : :' :
      http://debian.org || http://rapidpacket.com/~xtat    `. `' 
                                                             `-     ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20040515/e1330758/attachment.pgp

On Sat, 15 May 2004, Todd Troxell wrote:
> Eek, this is fairly critical as it has the potential to create a LOT of
> directories.  I think we should probably release before sargeing again
> unfortunately :\  I should have caught this one too.
> 
> Maybe just a fix release with only this change to be tested tomorrow?
Alfie won't be happy, but it agree that it's bad behaviour.
Don't think that this change needs a lot of testing,
it's pretty obvious.
 
> Also, any ideas about version numbering for fix releases?  It seems
> somehow inappropriate to mark this change .21, but if that is what
> is best, I will use it.
i prefered the subversioning you used before,
1.2.20-1?

hope that this one enters sarge :)

a++ maks

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url :
http://lists.alioth.debian.org/pipermail/logcheck-devel/attachments/20040515/8a348f35/attachment.pgp