[llvm-dev] Phabricator request for debuginfo-tests

David Blaikie via llvm-dev
Wed, 21 Oct 2020 22:49:52 -0000

Oh, right, sorry, was getting things confused/mixed up about "is it part of
llvm, is it part of the monorepo, is it in another repo". :/ Dunno what to
do about that then.

Hmm, wait, no - nevermind that. These tests are part of the monorepo:

https://github.com/llvm/llvm-project
https://github.com/llvm/llvm-project/debuginfo-tests
https://github.com/llvm/llvm-project/mlir

They seem to be on the same level as mlir and flang.

On Wed, Oct 21, 2020 at 3:43 PM Mehdi AMINI <joker.eph at gmail.com>
wrote:

>
>
> On Wed, Oct 21, 2020 at 3:37 PM David Blaikie <dblaikie at gmail.com>
wrote:
>
>>
>>
>> On Wed, Oct 21, 2020 at 3:32 PM Mehdi AMINI <joker.eph at
gmail.com> wrote:
>>
>>>
>>>
>>> On Wed, Oct 21, 2020 at 3:23 PM David Blaikie <dblaikie at
gmail.com>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Wed, Oct 21, 2020 at 3:22 PM Mehdi AMINI <joker.eph at
gmail.com>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> These are all plugged through global Herald rules in
general.
>>>>> It somehow relies on the monorepo to know how to dispatch
(path
>>>>> starting with LLVM -> llvm-commits@).
>>>>>
>>>>> I don't know what the rule should be for
debuginfo-tests?
>>>>>
>>>>
>>>> Same as LLVM I think would be good. (that's where the
commits mail is
>>>> going, pretty sure - so it's where the reviews should go)
>>>>
>>>
>>> I mean: I don't know how to detect that a patch is about the
debuginfo
>>> tests: if it is another repo, there won't be a leading path to
tell us like
>>> in the monorepo.
>>>
>>
>> Oh, sorry, I see - any idea how mlir, flang, etc, handle this then?
>>
>
> Like LLVM: by being in the monorepo they have a leading path discriminator.
>
> https://reviews.llvm.org/H591
> https://reviews.llvm.org/H615
> https://reviews.llvm.org/H607
> https://reviews.llvm.org/H600
>
>
>
>>
>>
>>>
>>>
>>>
>>>>
>>>>
>>>>>
>>>>> --
>>>>> Mehdi
>>>>>
>>>>>
>>>>> On Wed, Oct 21, 2020 at 1:02 PM David Blaikie <dblaikie
at gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Mehdi - any idea how this is rigged up/if this could be
fixed for the
>>>>>> debuginfo-tests repo?
>>>>>>
>>>>>> On Wed, Oct 21, 2020 at 12:38 PM David Blaikie
<dblaikie at gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> ah, indeed - my mistake!
>>>>>>>
>>>>>>> On Wed, Oct 21, 2020 at 12:34 PM Robinson, Paul
<
>>>>>>> paul.robinson at sony.com> wrote:
>>>>>>>
>>>>>>>> I’m talking about the “subscribed” field in a
Phab review, so that
>>>>>>>> the list sees the posted comments/reviews; you
seem to be talking about the
>>>>>>>> “this was committed” email which does come from
github.
>>>>>>>>
>>>>>>>> --paulr
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> *From:* David Blaikie <dblaikie at
gmail.com>
>>>>>>>> *Sent:* Wednesday, October 21, 2020 2:29 PM
>>>>>>>> *To:* Robinson, Paul <paul.robinson at
sony.com>
>>>>>>>> *Cc:* llvm-dev at lists.llvm.org
>>>>>>>> *Subject:* Re: [llvm-dev] Phabricator request
for debuginfo-tests
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Will follow-up more on the bug, but I don't
think the commits
>>>>>>>> mailing list mail is powered by phabricator at
all - it's some post-commit
>>>>>>>> hook in the VCS/github itself, I think.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Wed, Oct 21, 2020 at 6:35 AM Robinson, Paul
via llvm-dev <
>>>>>>>> llvm-dev at lists.llvm.org> wrote:
>>>>>>>>
>>>>>>>> Hi all,
>>>>>>>> I filed
https://bugs.llvm.org/show_bug.cgi?id=47934
>>>>>>>>
<https://urldefense.com/v3/__https:/bugs.llvm.org/show_bug.cgi?id=47934__;!!JmoZiZGBv3RvKRSx!ql6dBxeOus1GDl0ClfO1BlIfpD2O9XU4NmaiKCCM7MnDTVsiNP5p564p_NB2Q7xesw$>
>>>>>>>> asking to have
>>>>>>>> the debuginfo-tests project added to the list
of those that
>>>>>>>> subscribe
>>>>>>>> llvm-commits automatically.  But, it appears
that the Phabricator
>>>>>>>> component doesn't have anyone automatically
cc'd, and I suspect that
>>>>>>>> by failing to put [Phab] in the bug title,
whoever knows how to do
>>>>>>>> this won't notice the bug.
>>>>>>>>
>>>>>>>> So, how does that auto-subscription work?  Note
that historically,
>>>>>>>> I have always come out the worst when tangling
with Phabricator...
>>>>>>>> so I'll do it myself if necessary, if
someone can say what "it" is,
>>>>>>>> but it would be safer for someone else to do
the tweaking.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> --paulr
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> LLVM Developers mailing list
>>>>>>>> llvm-dev at lists.llvm.org
>>>>>>>>
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>>>>>>>
<https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev__;!!JmoZiZGBv3RvKRSx!ql6dBxeOus1GDl0ClfO1BlIfpD2O9XU4NmaiKCCM7MnDTVsiNP5p564p_NBOExc-LQ$>
>>>>>>>>
>>>>>>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20201021/992fabbd/attachment.html>