[llvm-dev] OrcV1 removal

Andres Freund via llvm-dev
Sun, 04 Oct 2020 21:04:56 -0000

Hi,

On 2020-10-02 11:12:45 -0700, Andres Freund via llvm-dev
wrote:
> The error reporting change also works and helps. Need to figure out on
> the PG side how to better associate the reported errors with the user
> action, but that's quite doable. Might just end up re-setting the error
> reporter on a more granular basis, to update the context.

One thing I noticed is that there's an unconditional error reporting
call:

LLJIT::~LLJIT() {
  if (CompileThreads)
    CompileThreads->wait();
  ES->reportError(ES->endSession());
}

Is that intentional? It's easy enough to check whether error is 0 in the
callback, but I don't want to do that if that's not what you intended
API wise.

Greetings,

Andres Freund