[llvm-dev] Renaming passes

Arthur Eubanks via llvm-dev
Thu, 25 Jun 2020 17:08:45 -0000

On Thu, Jun 25, 2020 at 9:59 AM Roman Lebedev <lebedev.ri at gmail.com>
wrote:

> On Thu, Jun 25, 2020 at 7:48 PM Arthur Eubanks via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
> >
> > After talking with some NPM people, I believe the ultimate goal after
> NPM is enabled by default is to only support `-passes=`, and remove support
> for `-foo-pass`.
> Hm, is there any written rationale behind such a decision?
> I would have thought that -passes= is the temporary solution, not the
> other way around.
>
This is really a separate issue that's somewhat orthogonal to the original
issue, but someone like asbirlea may be able to chime in more. Maybe a new
RFC thread?

>
> > However, until NPM is enabled by default, we still want tests using
opt
> to use the legacy PM by default.
> > We could attempt to make `-passes=` work with the legacy PM and have a
> legacy vs new PM flag, but given the design/syntax of `-passes=` I
don't
> think that's feasible (see llvm/include/llvm/Passes/PassBuilder.h).
> > So for making sure everything works with NPM, I think we need to
support
> `-foo-pass` in NPM to be able to run all opt tests against NPM. Then at
> some point after NPM is enabled by default we can attempt to migrate
> everything to `-passes=`.
>
> Roman.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200625/08bbda59/attachment.html>