[llvm-dev] [LLVM][DISubprogram][LL format updation query] Question regarding moving DISubprogram DIFlags to DISPFlag.

David Blaikie via llvm-dev
Thu, 20 Feb 2020 20:15:53 -0000

(+ the usual debug info folks just to highlight it/bring it to their
attention (I see Paul's already chimed in, but didn't want to leave him
out
;) ))

On Wed, Feb 19, 2020 at 10:51 PM Chirag Patel via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> Hello,
>
>
>
> In regard to the review request https://reviews.llvm.org/D74470,
>
> I am trying to move five of the DIFlags to DISPFlag for the moment namely
> DIFlagExplicit, DIFlagPrototyped, DIFlagNoReturn, DIFlagThunk,
> DIFlagAllCallsDescribed.
>
> The llvm ir format for DISubprogram currently has backword compatibility
> where the isLocal, isDefinition, virtuality, isOptimized and SPFlags are
> mutually exclusive.
>
> My question is,
>
> is it a good idea to remove the booleans support’(isLocal, isDefinition)
> and move most of it to spflags and flags in llvm ir? The llvm ir backward
> compatibility does not list the clear requirements on documentations page.
> This change affects more then 750 ll files.
>
>
>
> Regards,
>
> Chirag Partel.
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200220/9502e2b4/attachment.html>