[llvm-dev] [cfe-dev] Phabricator -> GitHub PRs?

Renato Golin via llvm-dev
Sat, 25 Jan 2020 20:54:06 -0000

On Fri, 24 Jan 2020 at 18:22, Doerfert, Johannes <jdoerfert at anl.gov>
wrote:
> > Single commits are harder to find cause of breakages and the commit
> > message may lose info if the merger is not the author.
>
> I don't understand:
>   - Single commits per feature should make it easier to find cause of
>     breakage. What do I misunderstand?

I meant single commit as in "whole patch series merged into one before
push".

This is usually a bad idea, unless the series is super-destructive and
the reviewers suggest a squash to minimise the damage.

One commit per feature / step is the best way, IMO, so I think we're
in agreement.

--renato