[llvm-dev] Phabricator -> GitHub PRs?

Christian Kühnel via llvm-dev
Wed, 22 Jan 2020 09:04:25 -0000

>
> In Github pull requests there is always a git commit that you can just
>> feed to the build server. And you can be sure of what really gets
merged.
>> You review, build and test exactly the change that gets merged
afterwards.
>>
>
> How would that be true? Given that upstream keep changing during the
> period of review? The commit is going to have to be rebased to head and
> that may involve making changes.
>

Yes, github tells you, that your PR has a merge conflict, that you need to
resolve manually. Once you've pushed the conflict resolution to the same
PR, it triggers another round of builds and tests. And also potentially
another review, depending on what permissions you have and how the project
ist set up...

--
Best,
Christian
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200122/8d8517db/attachment.html>