[llvm-dev] Enable Contributions Through Pull-request For LLVM

Hubert Tong via llvm-dev
2019-11-08T16:26:11Z

On Thu, Nov 7, 2019 at 1:09 PM Nemanja Ivanovic via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> TL; DR;
> As it was outlined by previous comments in the thread, the GitHub PR
> review tool is inferior to Phabricator (and I would argue that this is an
> objective statement). Those that are only familiar with GitHub may not
> ascribe much value to capabilities such as commenting on unchanged lines,
> expanding whatever context you're interested in, seeing the diff of two
> revisions, etc. But for a good portion of the LLVM community, these things
> are important.
>
A strong -1 to moving away from Phab.
+1 to Nemanja's comment re: the (lack of) quality in the GitHub PR
experience.

As for lowering the cost of entry for new developers, I will point out that
a bad review experience for reviewers does not improve communication
between existing community members and the new community members.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20191108/28238c8d/attachment.html>