[llvm-dev] [RFC] Remove Darwin support from POWER Backends

Kit Barton via llvm-dev
Fri, 24 Aug 2018 14:06:10 -0000

Thanks for the feedback everyone.

Does anyone know if there are any remaining darwin/ppc build bots? I looked
but could not find any yesterday. I think that is the last thing to take
care of before committing the patches.

Thanks,

Kit

On Thu, Aug 23, 2018 at 12:28 AM Chris Lattner <clattner at nondot.org>
wrote:

> 😥 it was nice knowing you darwin/ppc, but it is now time to say goodbye.
> +1 from me.
>
> -Chris
>
>
> > On Aug 20, 2018, at 12:42 PM, Kit Barton via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
> >
> > Hi all,
> > I just posted two patches on phabricator to remove Darwin support from
> the POWER backend.
> >
> > I thought I had posted this on the dev mailing list some time ago, but
I
> cannot find a reference to it now.
> >
> > The intention here is to cleanup the POWER backend. Darwin has not
been
> supported on POWER for quite some time now, and we'd like to use this
as an
> opportunity to clean up several aspects of the backend code. If there is
> any concerns with this, please let me know.
> >
> > As for the approach, the patch that I posted will issue an error
message
> from the backend if you attempt to use the Darwin ABI on PPC. The intention
> is that once this patch lands, all of the Darwin-specific code paths will
> essentially be dead-code, and we can remove them on demand as we're
> touching various pieces of code. This cleanup should be done in stand-alone
> patches, but can be done as NFC changes and thus reviewed post-commit,
> whenever possible.
> >
> > I've cleaned up all of the test cases effected by this, mostly by
> converting them to a different powerpc target so as to not lose test
> coverage. There were a few tests that were ppc-darwin specific, which were
> removed.
> >
> > There is a companion patch to clean up test cases in Clang as well. I
> think we can use a similar approach for cleaning up ppc-specific darwin
> code in Clang, although I don't have a good idea right now for how much
> cleanup that will be.
> >
> > Thanks.
> >
> > _______________________________________________
> > LLVM Developers mailing list
> > llvm-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180824/31826d3f/attachment.html>