[llvm-dev] RFC: [FileCheck] CHECK-DAG for multiple occurrences of string

Joel E. Denny via llvm-dev
Mon, 07 May 2018 17:06:50 -0000

Hi Paul,

On Mon, May 7, 2018 at 12:56 PM, <paul.robinson at sony.com> wrote:

> > 1. In a CHECK-DAG group, don't let the matches for patterns
overlap.
> > 2. Add a new CHECK-DAG-N directive, where N is some integer, to
express
> > that a pattern must have N non-overlapping matches.
>
> I think #1 is much more intuitive and easy to describe/document than #2.
>

Agreed.


> Changing the meaning of DAG in that way is highly unlikely to affect any
> existing test, IMO.  And if it does, my first expectation is that the test
> wasn't doing what the author intended anyway.
>

I'm glad to hear that.  I'll look into #1.

Thanks.

Joel


> --paulr
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20180507/dad25970/attachment.html>