[llvm-dev] ABI Breaking Checks

David Blaikie via llvm-dev
Tue, 28 Nov 2017 22:35:44 -0000

The abi-breaking.h seems to be incompatible with modules, owing to it
having strong definitions in the header.

I'm wondering if I can make it compatible by changing the:

__attribute__((weak, visibility("hidden"))) variables to
__attribute__((used)) static variables instead? It still seems to produce
the desired link errors in my basic tests. Does that seem plausible to you?

(modules have a special case for static variables in headers to support
things like the iostreams initializer)

Not sure why the modules buildbots don't see this but google's internal
build system building with modules does...

- Dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20171128/20511715/attachment.html>