[LLVMdev] Phabricator and private reviews

Reid Kleckner
2014-06-25T18:13:23Z

Can you provide some data to support this by comparing commits with phab
URLs in them with the llvm-commits archive?

It may be that llvm-commits is properly forwarding the review mail, but
it's getting caught in people's spam filters.  I've personally had
problems
with this.


On Wed, Jun 25, 2014 at 10:44 AM, Alp Toker <alp at nuanti.com> wrote:

> For whatever reason, patches posted to the Phabricator website still
> aren't being sent to the mailing list, making it difficult for us to
review
> them.
>
> I've raised this issue a couple of times in the last few weeks.
>
> In practice this has a detrimental effect to the development workflow
> because it means that code is being seen only by a small group of
> individuals who have web accounts. The code isn't hitting llvm-commits
or
> cfe-commits where the majority of code maintainers use the mailing lists
> for review.
>
> At this point I think Phabricator should be disabled and patches should be
> send to the mailing lists *until* the technical issue is confirmed
resolved.
>
> It's really uncool that code is entering ToT through this back-channel
--
> I appreciate that it might not be intentional, but every single patch that
> gets committed this way is a real problem for the project.
>
> Alp.
>
> --
> http://www.nuanti.com
> the browser experts
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20140625/6f550786/attachment.html>