[LLVMdev] Phabricator and private reviews

Philip Reames
2014-06-25T18:15:46Z

I also object to this proposal.

At least some of the issues have been resolved.  In my particular case,
I had an invalid email listed in phabricator.  Rather than simply
effecting my own emails, this was preventing phabricator from notifying
for entire threads of review discussion (to *anyone*). It's possible
others have this issue as well.

If you notice threads which are not making it to the mailing list, why
don't you point them out here?

I do think it's worth asking everyone to double check that a phabricator
review has made it to the commits list before submission.  If not, they
should manually forward the link and give time for comments on the
public commits list.  At the end of the day, the commits list is our
"source of truth", not the phabricator review.

Philip


On 06/25/2014 10:59 AM, Eric Christopher wrote:
> I don't think it's all patches. I've had plenty of patches go
up and
> get reviewed with the reviews going to the list lately.
>
> I'm going to object to this proposal.
>
> -eric
>
> On Wed, Jun 25, 2014 at 10:44 AM, Alp Toker <alp at nuanti.com>
wrote:
>> For whatever reason, patches posted to the Phabricator website still
aren't
>> being sent to the mailing list, making it difficult for us to review
them.
>>
>> I've raised this issue a couple of times in the last few weeks.
>>
>> In practice this has a detrimental effect to the development workflow
>> because it means that code is being seen only by a small group of
>> individuals who have web accounts. The code isn't hitting
llvm-commits or
>> cfe-commits where the majority of code maintainers use the mailing
lists for
>> review.
>>
>> At this point I think Phabricator should be disabled and patches should
be
>> send to the mailing lists *until* the technical issue is confirmed
resolved.
>>
>> It's really uncool that code is entering ToT through this
back-channel -- I
>> appreciate that it might not be intentional, but every single patch
that
>> gets committed this way is a real problem for the project.
>>
>> Alp.
>>
>> --
>> http://www.nuanti.com
>> the browser experts
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev